build-remove-calling-untrusted-hooks.patch 4.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154
  1. From: Jan Engelhardt <jengelh@inai.de>
  2. Date: Thu, 20 Apr 2017 16:25:49 +0200
  3. Subject: build: remove calling untrusted hooks
  4. Avoid downloading untrusted executables and wasting time with a
  5. sysroot.
  6. ---
  7. DEPS | 96 ++----------------------------------------------------------
  8. 1 file changed, 3 insertions(+), 93 deletions(-)
  9. diff --git a/DEPS b/DEPS
  10. --- a/DEPS
  11. +++ b/DEPS
  12. @@ -81,7 +81,7 @@ vars = {
  13. # Check out and download nacl by default. This can be disabled e.g. with
  14. # custom_vars.
  15. - 'checkout_nacl': True,
  16. + 'checkout_nacl': False,
  17. # By default, do not check out src-internal. This can be overridden e.g. with
  18. # custom_vars.
  19. @@ -108,8 +108,8 @@ vars = {
  20. # support for other platforms may be added in the future.
  21. 'checkout_openxr' : 'checkout_win',
  22. - 'checkout_traffic_annotation_tools': 'checkout_configuration != "small"',
  23. - 'checkout_instrumented_libraries': 'checkout_linux and checkout_configuration != "small"',
  24. + 'checkout_traffic_annotation_tools': False,
  25. + 'checkout_instrumented_libraries': False,
  26. # By default, do not check out WebKit for iOS, as it is not needed unless
  27. # running against ToT WebKit rather than system WebKit. This can be overridden
  28. @@ -3502,49 +3502,6 @@ hooks = [
  29. 'sync', '--extract',
  30. ],
  31. },
  32. - {
  33. - 'name': 'sysroot_arm',
  34. - 'pattern': '.',
  35. - 'condition': 'checkout_linux and checkout_arm',
  36. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  37. - '--arch=arm'],
  38. - },
  39. - {
  40. - 'name': 'sysroot_arm64',
  41. - 'pattern': '.',
  42. - 'condition': 'checkout_linux and checkout_arm64',
  43. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  44. - '--arch=arm64'],
  45. - },
  46. - {
  47. - 'name': 'sysroot_x86',
  48. - 'pattern': '.',
  49. - 'condition': 'checkout_linux and (checkout_x86 or checkout_x64)',
  50. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  51. - '--arch=x86'],
  52. - },
  53. - {
  54. - 'name': 'sysroot_mips',
  55. - 'pattern': '.',
  56. - 'condition': 'checkout_linux and checkout_mips',
  57. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  58. - '--arch=mips'],
  59. - },
  60. - {
  61. - 'name': 'sysroot_mips64',
  62. - 'pattern': '.',
  63. - 'condition': 'checkout_linux and checkout_mips64',
  64. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  65. - '--arch=mips64el'],
  66. - },
  67. -
  68. - {
  69. - 'name': 'sysroot_x64',
  70. - 'pattern': '.',
  71. - 'condition': 'checkout_linux and checkout_x64',
  72. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  73. - '--arch=x64'],
  74. - },
  75. {
  76. # Case-insensitivity for the Win SDK. Must run before win_toolchain below.
  77. 'name': 'ciopfs_linux',
  78. @@ -3572,18 +3529,6 @@ hooks = [
  79. 'condition': 'checkout_mac',
  80. 'action': ['python', 'src/build/mac_toolchain.py'],
  81. },
  82. - # Pull binutils for linux, enabled debug fission for faster linking /
  83. - # debugging when used with clang on Ubuntu Precise.
  84. - # https://code.google.com/p/chromium/issues/detail?id=352046
  85. - {
  86. - 'name': 'binutils',
  87. - 'pattern': 'src/third_party/binutils',
  88. - 'condition': 'host_os == "linux" and host_cpu != "mips64"',
  89. - 'action': [
  90. - 'python',
  91. - 'src/third_party/binutils/download.py',
  92. - ],
  93. - },
  94. {
  95. # Update the prebuilt clang toolchain.
  96. # Note: On Win, this should run after win_toolchain, as it may use it.
  97. @@ -3679,18 +3624,6 @@ hooks = [
  98. '-s', 'src/buildtools/mac/clang-format.sha1',
  99. ],
  100. },
  101. - {
  102. - 'name': 'clang_format_linux',
  103. - 'pattern': '.',
  104. - 'condition': 'host_os == "linux"',
  105. - 'action': [ 'python',
  106. - 'src/third_party/depot_tools/download_from_google_storage.py',
  107. - '--no_resume',
  108. - '--no_auth',
  109. - '--bucket', 'chromium-clang-format',
  110. - '-s', 'src/buildtools/linux64/clang-format.sha1',
  111. - ],
  112. - },
  113. # Pull rc binaries using checked-in hashes.
  114. {
  115. 'name': 'rc_win',
  116. @@ -3716,29 +3649,6 @@ hooks = [
  117. '-s', 'src/build/toolchain/win/rc/mac/rc.sha1',
  118. ],
  119. },
  120. - {
  121. - 'name': 'rc_linux',
  122. - 'pattern': '.',
  123. - 'condition': 'checkout_win and host_os == "linux"',
  124. - 'action': [ 'python',
  125. - 'src/third_party/depot_tools/download_from_google_storage.py',
  126. - '--no_resume',
  127. - '--no_auth',
  128. - '--bucket', 'chromium-browser-clang/rc',
  129. - '-s', 'src/build/toolchain/win/rc/linux64/rc.sha1',
  130. - ]
  131. - },
  132. - {
  133. - 'name': 'test_fonts',
  134. - 'pattern': '.',
  135. - 'action': [ 'download_from_google_storage',
  136. - '--no_resume',
  137. - '--extract',
  138. - '--no_auth',
  139. - '--bucket', 'chromium-fonts',
  140. - '-s', 'src/third_party/test_fonts/test_fonts.tar.gz.sha1',
  141. - ],
  142. - },
  143. # Download test resources for opus, i.e. audio files.
  144. {
  145. 'name': 'opus_test_files',
  146. --
  147. 2.17.1