Remove-dependency-on-com.google.android.gms.auth.patch 8.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186
  1. From: Wengling Chen <feiyu2817@gmail.com>
  2. Date: Sat, 2 Nov 2019 09:22:31 +0100
  3. Subject: Remove dependency on com.google.android.gms.auth
  4. ---
  5. chrome/android/BUILD.gn | 1 -
  6. .../signin/core/browser/android/BUILD.gn | 1 -
  7. .../components/signin/AccountIdProvider.java | 10 +----
  8. .../signin/SystemAccountManagerDelegate.java | 15 +------
  9. content/public/android/BUILD.gn | 1 -
  10. content/test/BUILD.gn | 1 -
  11. third_party/android_deps/BUILD.gn | 44 -------------------
  12. third_party/robolectric/BUILD.gn | 1 -
  13. 8 files changed, 2 insertions(+), 72 deletions(-)
  14. diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
  15. --- a/chrome/android/BUILD.gn
  16. +++ b/chrome/android/BUILD.gn
  17. @@ -222,7 +222,6 @@ android_library("chrome_java") {
  18. ":partner_location_descriptor_proto_java",
  19. ":update_proto_java",
  20. ":usage_stats_proto_java",
  21. - "$google_play_services_package:google_play_services_auth_base_java",
  22. "$google_play_services_package:google_play_services_base_java",
  23. "$google_play_services_package:google_play_services_basement_java",
  24. "$google_play_services_package:google_play_services_cast_framework_java",
  25. diff --git a/components/signin/core/browser/android/BUILD.gn b/components/signin/core/browser/android/BUILD.gn
  26. --- a/components/signin/core/browser/android/BUILD.gn
  27. +++ b/components/signin/core/browser/android/BUILD.gn
  28. @@ -14,7 +14,6 @@ generate_jni("jni_headers") {
  29. android_library("java") {
  30. deps = [
  31. - "$google_play_services_package:google_play_services_auth_base_java",
  32. "$google_play_services_package:google_play_services_base_java",
  33. "$google_play_services_package:google_play_services_basement_java",
  34. "//base:base_java",
  35. diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountIdProvider.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountIdProvider.java
  36. --- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountIdProvider.java
  37. +++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountIdProvider.java
  38. @@ -6,9 +6,6 @@ package org.chromium.components.signin;
  39. import androidx.annotation.VisibleForTesting;
  40. -import com.google.android.gms.common.ConnectionResult;
  41. -import com.google.android.gms.common.GoogleApiAvailability;
  42. -
  43. import org.chromium.base.ContextUtils;
  44. import org.chromium.base.Log;
  45. import org.chromium.base.StrictModeContext;
  46. @@ -48,12 +45,7 @@ public class AccountIdProvider {
  47. * Google Play services is available.
  48. */
  49. public boolean canBeUsed() {
  50. - // TODO(http://crbug.com/577190): Remove StrictMode override.
  51. - try (StrictModeContext ignored = StrictModeContext.allowDiskWrites()) {
  52. - int resultCode = GoogleApiAvailability.getInstance().isGooglePlayServicesAvailable(
  53. - ContextUtils.getApplicationContext());
  54. - return resultCode == ConnectionResult.SUCCESS;
  55. - }
  56. + return false;
  57. }
  58. /**
  59. diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
  60. --- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
  61. +++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
  62. @@ -24,9 +24,6 @@ import android.os.PatternMatcher;
  63. import android.os.Process;
  64. import android.os.SystemClock;
  65. -import com.google.android.gms.common.ConnectionResult;
  66. -import com.google.android.gms.common.GoogleApiAvailability;
  67. -
  68. import org.chromium.base.ApiCompatibilityUtils;
  69. import org.chromium.base.Callback;
  70. import org.chromium.base.ContextUtils;
  71. @@ -82,17 +79,7 @@ public class SystemAccountManagerDelegate implements AccountManagerDelegate {
  72. }
  73. protected void checkCanUseGooglePlayServices() throws AccountManagerDelegateException {
  74. - Context context = ContextUtils.getApplicationContext();
  75. - final int resultCode =
  76. - GoogleApiAvailability.getInstance().isGooglePlayServicesAvailable(context);
  77. - if (resultCode == ConnectionResult.SUCCESS) {
  78. - return;
  79. - }
  80. -
  81. - throw new GmsAvailabilityException(
  82. - String.format("Can't use Google Play Services: %s",
  83. - GoogleApiAvailability.getInstance().getErrorString(resultCode)),
  84. - resultCode);
  85. + throw new GmsAvailabilityException("Can't use Google Play Services", 1);
  86. }
  87. @Override
  88. diff --git a/content/public/android/BUILD.gn b/content/public/android/BUILD.gn
  89. --- a/content/public/android/BUILD.gn
  90. +++ b/content/public/android/BUILD.gn
  91. @@ -49,7 +49,6 @@ action("generate_sandboxed_service_srcjar") {
  92. android_library("content_java") {
  93. deps = [
  94. ":content_java_resources",
  95. - "$google_play_services_package:google_play_services_auth_api_phone_java",
  96. "$google_play_services_package:google_play_services_base_java",
  97. "$google_play_services_package:google_play_services_basement_java",
  98. "$google_play_services_package:google_play_services_tasks_java",
  99. diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
  100. --- a/content/test/BUILD.gn
  101. +++ b/content/test/BUILD.gn
  102. @@ -2344,7 +2344,6 @@ if (is_android) {
  103. testonly = true
  104. sources = content_java_sources_needing_jni
  105. deps = [
  106. - "$google_play_services_package:google_play_services_auth_api_phone_java",
  107. "$google_play_services_package:google_play_services_base_java",
  108. "$google_play_services_package:google_play_services_basement_java",
  109. "$google_play_services_package:google_play_services_tasks_java",
  110. diff --git a/third_party/android_deps/BUILD.gn b/third_party/android_deps/BUILD.gn
  111. --- a/third_party/android_deps/BUILD.gn
  112. +++ b/third_party/android_deps/BUILD.gn
  113. @@ -850,50 +850,6 @@ java_prebuilt("com_android_tools_build_jetifier_jetifier_processor_java") {
  114. ]
  115. }
  116. -# This is generated, do not edit. Update BuildConfigGenerator.groovy instead.
  117. -android_aar_prebuilt("google_play_services_auth_java") {
  118. - aar_path = "libs/com_google_android_gms_play_services_auth/play-services-auth-15.0.1.aar"
  119. - info_path = "libs/com_google_android_gms_play_services_auth/com_google_android_gms_play_services_auth.info"
  120. - deps = [
  121. - ":google_play_services_auth_api_phone_java",
  122. - ":google_play_services_auth_base_java",
  123. - ":google_play_services_base_java",
  124. - ":google_play_services_basement_java",
  125. - ":google_play_services_tasks_java",
  126. - ]
  127. -
  128. - # Removing drawables from GMS .aars as they are unused bloat.
  129. - strip_drawables = true
  130. -}
  131. -
  132. -# This is generated, do not edit. Update BuildConfigGenerator.groovy instead.
  133. -android_aar_prebuilt("google_play_services_auth_api_phone_java") {
  134. - aar_path = "libs/com_google_android_gms_play_services_auth_api_phone/play-services-auth-api-phone-15.0.1.aar"
  135. - info_path = "libs/com_google_android_gms_play_services_auth_api_phone/com_google_android_gms_play_services_auth_api_phone.info"
  136. - deps = [
  137. - ":google_play_services_base_java",
  138. - ":google_play_services_basement_java",
  139. - ":google_play_services_tasks_java",
  140. - ]
  141. -
  142. - # Removing drawables from GMS .aars as they are unused bloat.
  143. - strip_drawables = true
  144. -}
  145. -
  146. -# This is generated, do not edit. Update BuildConfigGenerator.groovy instead.
  147. -android_aar_prebuilt("google_play_services_auth_base_java") {
  148. - aar_path = "libs/com_google_android_gms_play_services_auth_base/play-services-auth-base-15.0.1.aar"
  149. - info_path = "libs/com_google_android_gms_play_services_auth_base/com_google_android_gms_play_services_auth_base.info"
  150. - deps = [
  151. - ":google_play_services_base_java",
  152. - ":google_play_services_basement_java",
  153. - ":google_play_services_tasks_java",
  154. - ]
  155. -
  156. - # Removing drawables from GMS .aars as they are unused bloat.
  157. - strip_drawables = true
  158. -}
  159. -
  160. # This is generated, do not edit. Update BuildConfigGenerator.groovy instead.
  161. android_aar_prebuilt("google_play_services_base_java") {
  162. aar_path = "libs/com_google_android_gms_play_services_base/play-services-base-15.0.1.aar"
  163. diff --git a/third_party/robolectric/BUILD.gn b/third_party/robolectric/BUILD.gn
  164. --- a/third_party/robolectric/BUILD.gn
  165. +++ b/third_party/robolectric/BUILD.gn
  166. @@ -939,7 +939,6 @@ java_library("shadows_play_services_java") {
  167. ":robolectric_shadowapi_java",
  168. ":robolectric_utils_java",
  169. ":shadows_core_java",
  170. - "$google_play_services_package:google_play_services_auth_base_java",
  171. "$google_play_services_package:google_play_services_base_java",
  172. "$google_play_services_package:google_play_services_basement_java",
  173. "//third_party/android_deps:android_support_v4_java",
  174. --
  175. 2.17.1