Allow-building-without-feed-support.patch 7.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119
  1. From: csagan5 <32685696+csagan5@users.noreply.github.com>
  2. Date: Thu, 19 Dec 2019 22:52:53 +0100
  3. Subject: Allow building without feed support
  4. ---
  5. .../start_surface/StartSurfaceCoordinator.java | 5 -----
  6. .../start_surface/StartSurfaceMediator.java | 17 -----------------
  7. chrome/android/feed/feed_java_sources.gni | 2 --
  8. .../browser/native_page/NativePageFactory.java | 7 -------
  9. components/feed/feed_feature_list.cc | 2 +-
  10. 5 files changed, 1 insertion(+), 32 deletions(-)
  11. diff --git a/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceCoordinator.java b/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceCoordinator.java
  12. --- a/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceCoordinator.java
  13. +++ b/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceCoordinator.java
  14. @@ -214,11 +214,6 @@ public class StartSurfaceCoordinator implements StartSurface {
  15. mBottomBarCoordinator = new BottomBarCoordinator(
  16. mActivity, mActivity.getCompositorViewHolder(), mPropertyModel);
  17. }
  18. -
  19. - mExploreSurfaceCoordinator = new ExploreSurfaceCoordinator(mActivity,
  20. - mSurfaceMode == SurfaceMode.SINGLE_PANE ? mTasksSurface.getBodyViewContainer()
  21. - : mActivity.getCompositorViewHolder(),
  22. - mPropertyModel, mSurfaceMode == SurfaceMode.SINGLE_PANE);
  23. }
  24. private TabSwitcher.Controller initializeSecondaryTasksSurface() {
  25. diff --git a/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceMediator.java b/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceMediator.java
  26. --- a/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceMediator.java
  27. +++ b/chrome/android/features/start_surface/internal/java/src/org/chromium/chrome/features/start_surface/StartSurfaceMediator.java
  28. @@ -415,15 +415,6 @@ class StartSurfaceMediator
  29. assert (isShownState(shownState));
  30. setOverviewState(shownState);
  31. - // Make sure FeedSurfaceCoordinator is built before the explore surface is showing by
  32. - // default.
  33. - if (mPropertyModel.get(IS_EXPLORE_SURFACE_VISIBLE)
  34. - && mPropertyModel.get(FEED_SURFACE_COORDINATOR) == null
  35. - && !mActivityStateChecker.isFinishingOrDestroyed()) {
  36. - mPropertyModel.set(FEED_SURFACE_COORDINATOR,
  37. - mFeedSurfaceCreator.createFeedSurfaceCoordinator(
  38. - mNightModeStateProvider.isInNightMode()));
  39. - }
  40. mTabModelSelector.addObserver(mTabModelSelectorObserver);
  41. if (mFullScreenListener != null) {
  42. @@ -536,14 +527,6 @@ class StartSurfaceMediator
  43. private void setExploreSurfaceVisibility(boolean isVisible) {
  44. if (isVisible == mPropertyModel.get(IS_EXPLORE_SURFACE_VISIBLE)) return;
  45. - if (isVisible && mPropertyModel.get(IS_SHOWING_OVERVIEW)
  46. - && mPropertyModel.get(FEED_SURFACE_COORDINATOR) == null
  47. - && !mActivityStateChecker.isFinishingOrDestroyed()) {
  48. - mPropertyModel.set(FEED_SURFACE_COORDINATOR,
  49. - mFeedSurfaceCreator.createFeedSurfaceCoordinator(
  50. - mNightModeStateProvider.isInNightMode()));
  51. - }
  52. -
  53. mPropertyModel.set(IS_EXPLORE_SURFACE_VISIBLE, isVisible);
  54. if (mOverviewModeState == OverviewModeState.SHOWN_TABSWITCHER_TWO_PANES) {
  55. diff --git a/chrome/android/feed/feed_java_sources.gni b/chrome/android/feed/feed_java_sources.gni
  56. --- a/chrome/android/feed/feed_java_sources.gni
  57. +++ b/chrome/android/feed/feed_java_sources.gni
  58. @@ -35,7 +35,6 @@ if (enable_feed_in_chrome) {
  59. "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLifecycleBridge.java",
  60. "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java",
  61. "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNetworkBridge.java",
  62. - "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java",
  63. "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedOfflineBridge.java",
  64. "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedOfflineIndicator.java",
  65. "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java",
  66. @@ -736,7 +735,6 @@ if (enable_feed_in_chrome) {
  67. feed_deps = []
  68. feed_java_sources = [
  69. "//chrome/android/feed/dummy/java/src/org/chromium/chrome/browser/feed/FeedAppLifecycle.java",
  70. - "//chrome/android/feed/dummy/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java",
  71. "//chrome/android/feed/dummy/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java",
  72. "//chrome/android/feed/dummy/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java",
  73. "//chrome/android/feed/dummy/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java",
  74. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java
  75. --- a/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java
  76. +++ b/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java
  77. @@ -17,7 +17,6 @@ import org.chromium.chrome.browser.ChromeActivity;
  78. import org.chromium.chrome.browser.bookmarks.BookmarkPage;
  79. import org.chromium.chrome.browser.download.DownloadPage;
  80. import org.chromium.chrome.browser.explore_sites.ExploreSitesPage;
  81. -import org.chromium.chrome.browser.feed.FeedNewTabPage;
  82. import org.chromium.chrome.browser.flags.ChromeFeatureList;
  83. import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
  84. import org.chromium.chrome.browser.history.HistoryPage;
  85. @@ -57,12 +56,6 @@ public class NativePageFactory {
  86. activity, new TabShim(tab, activity.getFullscreenManager()));
  87. }
  88. - if (ChromeFeatureList.isEnabled(ChromeFeatureList.INTEREST_FEED_CONTENT_SUGGESTIONS)) {
  89. - return new FeedNewTabPage(activity,
  90. - new TabShim(tab, activity.getFullscreenManager()), tabModelSelector,
  91. - activityTabProvider, activityLifecycleDispatcher, (TabImpl) tab);
  92. - }
  93. -
  94. return new NewTabPage(activity, new TabShim(tab, activity.getFullscreenManager()),
  95. tabModelSelector, activityTabProvider, activityLifecycleDispatcher,
  96. (TabImpl) tab);
  97. diff --git a/components/feed/feed_feature_list.cc b/components/feed/feed_feature_list.cc
  98. --- a/components/feed/feed_feature_list.cc
  99. +++ b/components/feed/feed_feature_list.cc
  100. @@ -7,7 +7,7 @@
  101. namespace feed {
  102. const base::Feature kInterestFeedContentSuggestions{
  103. - "InterestFeedContentSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
  104. + "InterestFeedContentSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
  105. const base::FeatureParam<std::string> kDisableTriggerTypes{
  106. &kInterestFeedContentSuggestions, "disable_trigger_types", ""};
  107. --
  108. 2.17.1