1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071 |
- From: csagan5 <32685696+csagan5@users.noreply.github.com>
- Date: Mon, 2 Dec 2019 21:15:32 +0100
- Subject: Revert "flags: remove disable-pull-to-refresh-effect"
- This reverts commit 4e598f38a0e6dd3dbede009c6a99b2a520a94e1f.
- ---
- chrome/browser/about_flags.cc | 4 ++++
- chrome/browser/flag-metadata.json | 5 +++++
- chrome/browser/flag_descriptions.cc | 4 ++++
- chrome/browser/flag_descriptions.h | 3 +++
- 4 files changed, 16 insertions(+)
- diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
- --- a/chrome/browser/about_flags.cc
- +++ b/chrome/browser/about_flags.cc
- @@ -3269,6 +3269,10 @@ const FeatureEntry kFeatureEntries[] = {
- SINGLE_VALUE_TYPE(switches::kHostedAppQuitNotification)},
- #endif // OS_MAC
- #if defined(OS_ANDROID)
- + {"disable-pull-to-refresh-effect",
- + flag_descriptions::kPullToRefreshEffectName,
- + flag_descriptions::kPullToRefreshEffectDescription, kOsAndroid,
- + SINGLE_DISABLE_VALUE_TYPE(switches::kDisablePullToRefreshEffect)},
- {"translate-force-trigger-on-english",
- flag_descriptions::kTranslateForceTriggerOnEnglishName,
- flag_descriptions::kTranslateForceTriggerOnEnglishDescription, kOsAndroid,
- diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
- --- a/chrome/browser/flag-metadata.json
- +++ b/chrome/browser/flag-metadata.json
- @@ -1107,6 +1107,11 @@
- // enable-javascript-harmony.
- "expiry_milestone": -1
- },
- + {
- + "name": "disable-pull-to-refresh-effect",
- + // "owners": [ "your-team" ],
- + "expiry_milestone": -1
- + },
- {
- "name": "disable-keepalive-fetch",
- "owners": [ "yhirano" ],
- diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
- --- a/chrome/browser/flag_descriptions.cc
- +++ b/chrome/browser/flag_descriptions.cc
- @@ -3302,6 +3302,10 @@ const char kReadLaterDescription[] =
- "Allow users to save tabs for later. Enables a new button and menu for "
- "accessing tabs saved for later.";
-
- +const char kPullToRefreshEffectName[] = "The pull-to-refresh effect";
- +const char kPullToRefreshEffectDescription[] =
- + "Page reloads triggered by vertically overscrolling content.";
- +
- const char kReaderModeHeuristicsName[] = "Reader Mode triggering";
- const char kReaderModeHeuristicsDescription[] =
- "Determines what pages the Reader Mode infobar is shown on.";
- diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
- --- a/chrome/browser/flag_descriptions.h
- +++ b/chrome/browser/flag_descriptions.h
- @@ -1908,6 +1908,9 @@ extern const char kQueryTilesMoreTrendingDescription[];
- extern const char kQueryTilesSwapTrendingName[];
- extern const char kQueryTilesSwapTrendingDescription[];
-
- +extern const char kPullToRefreshEffectName[];
- +extern const char kPullToRefreshEffectDescription[];
- +
- extern const char kReaderModeHeuristicsName[];
- extern const char kReaderModeHeuristicsDescription[];
- extern const char kReaderModeHeuristicsMarkup[];
- --
- 2.17.1
|