Revert-flags-remove-disable-pull-to-refresh-effect.patch 2.9 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071
  1. From: csagan5 <32685696+csagan5@users.noreply.github.com>
  2. Date: Mon, 2 Dec 2019 21:15:32 +0100
  3. Subject: Revert "flags: remove disable-pull-to-refresh-effect"
  4. This reverts commit 4e598f38a0e6dd3dbede009c6a99b2a520a94e1f.
  5. ---
  6. chrome/browser/about_flags.cc | 4 ++++
  7. chrome/browser/flag-metadata.json | 5 +++++
  8. chrome/browser/flag_descriptions.cc | 4 ++++
  9. chrome/browser/flag_descriptions.h | 3 +++
  10. 4 files changed, 16 insertions(+)
  11. diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
  12. --- a/chrome/browser/about_flags.cc
  13. +++ b/chrome/browser/about_flags.cc
  14. @@ -3269,6 +3269,10 @@ const FeatureEntry kFeatureEntries[] = {
  15. SINGLE_VALUE_TYPE(switches::kHostedAppQuitNotification)},
  16. #endif // OS_MAC
  17. #if defined(OS_ANDROID)
  18. + {"disable-pull-to-refresh-effect",
  19. + flag_descriptions::kPullToRefreshEffectName,
  20. + flag_descriptions::kPullToRefreshEffectDescription, kOsAndroid,
  21. + SINGLE_DISABLE_VALUE_TYPE(switches::kDisablePullToRefreshEffect)},
  22. {"translate-force-trigger-on-english",
  23. flag_descriptions::kTranslateForceTriggerOnEnglishName,
  24. flag_descriptions::kTranslateForceTriggerOnEnglishDescription, kOsAndroid,
  25. diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
  26. --- a/chrome/browser/flag-metadata.json
  27. +++ b/chrome/browser/flag-metadata.json
  28. @@ -1107,6 +1107,11 @@
  29. // enable-javascript-harmony.
  30. "expiry_milestone": -1
  31. },
  32. + {
  33. + "name": "disable-pull-to-refresh-effect",
  34. + // "owners": [ "your-team" ],
  35. + "expiry_milestone": -1
  36. + },
  37. {
  38. "name": "disable-keepalive-fetch",
  39. "owners": [ "yhirano" ],
  40. diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
  41. --- a/chrome/browser/flag_descriptions.cc
  42. +++ b/chrome/browser/flag_descriptions.cc
  43. @@ -3302,6 +3302,10 @@ const char kReadLaterDescription[] =
  44. "Allow users to save tabs for later. Enables a new button and menu for "
  45. "accessing tabs saved for later.";
  46. +const char kPullToRefreshEffectName[] = "The pull-to-refresh effect";
  47. +const char kPullToRefreshEffectDescription[] =
  48. + "Page reloads triggered by vertically overscrolling content.";
  49. +
  50. const char kReaderModeHeuristicsName[] = "Reader Mode triggering";
  51. const char kReaderModeHeuristicsDescription[] =
  52. "Determines what pages the Reader Mode infobar is shown on.";
  53. diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
  54. --- a/chrome/browser/flag_descriptions.h
  55. +++ b/chrome/browser/flag_descriptions.h
  56. @@ -1908,6 +1908,9 @@ extern const char kQueryTilesMoreTrendingDescription[];
  57. extern const char kQueryTilesSwapTrendingName[];
  58. extern const char kQueryTilesSwapTrendingDescription[];
  59. +extern const char kPullToRefreshEffectName[];
  60. +extern const char kPullToRefreshEffectDescription[];
  61. +
  62. extern const char kReaderModeHeuristicsName[];
  63. extern const char kReaderModeHeuristicsDescription[];
  64. extern const char kReaderModeHeuristicsMarkup[];
  65. --
  66. 2.17.1