12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788 |
- From: Serg <serg.zhukovsky@gmail.com>
- Date: Tue, 31 Jan 2017 22:12:27 -0500
- Subject: Add exit menu item
- Corrected Exit functionality
- ---
- chrome/android/java/res/menu/main_menu.xml | 4 ++++
- .../src/org/chromium/chrome/browser/app/ChromeActivity.java | 6 ++++++
- .../chrome/browser/init/ChromeLifetimeController.java | 6 +++++-
- .../browser/ui/android/strings/android_chrome_strings.grd | 3 +++
- 4 files changed, 18 insertions(+), 1 deletion(-)
- diff --git a/chrome/android/java/res/menu/main_menu.xml b/chrome/android/java/res/menu/main_menu.xml
- --- a/chrome/android/java/res/menu/main_menu.xml
- +++ b/chrome/android/java/res/menu/main_menu.xml
- @@ -116,6 +116,8 @@
- android:icon="@drawable/vr_headset" />
- <item android:id="@+id/managed_by_menu_id"
- android:title="@string/managed" />
- + <item android:id="@+id/exit_id"
- + android:title="@string/menu_exit" />
- </group>
-
- <!-- Items shown only in the tab switcher -->
- @@ -139,6 +141,8 @@
- <item android:id="@id/preferences_id"
- android:title="@string/menu_settings"
- android:icon="@drawable/settings_cog" />
- + <item android:id="@+id/exit_id"
- + android:title="@string/menu_exit" />
- </group>
-
- <!-- Items shown only in the tab switcher when start surface is enabled -->
- diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
- --- a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
- +++ b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
- @@ -53,6 +53,7 @@ import org.chromium.base.supplier.ObservableSupplierImpl;
- import org.chromium.chrome.R;
- import org.chromium.chrome.browser.ActivityTabProvider;
- import org.chromium.chrome.browser.AppHooks;
- +import org.chromium.chrome.browser.ApplicationLifetime;
- import org.chromium.chrome.browser.ChromeActivitySessionTracker;
- import org.chromium.chrome.browser.ChromeApplication;
- import org.chromium.chrome.browser.ChromeVersionInfo;
- @@ -1874,6 +1875,11 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
- RecordUserAction.record("MobileMenuSettings");
- }
-
- + if (id == R.id.exit_id) {
- + ApplicationLifetime.terminate(false);
- + return true;
- + }
- +
- if (id == R.id.update_menu_id) {
- UpdateMenuItemHelper.getInstance().onMenuItemClicked(this);
- return true;
- diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
- --- a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
- +++ b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
- @@ -82,7 +82,11 @@ class ChromeLifetimeController implements ApplicationLifetime.Observer,
-
- // Kick off a timer to kill the process after a delay, which fires only if the Activities
- // take too long to be finished.
- - mHandler.postDelayed(mRestartRunnable, WATCHDOG_DELAY_MS);
- + if (restart) {
- + mHandler.postDelayed(mRestartRunnable, WATCHDOG_DELAY_MS);
- + } else {
- + fireBrowserRestartActivityIntent();
- + }
- }
-
- @Override
- diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
- --- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
- +++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
- @@ -2698,6 +2698,9 @@ To change this setting, <ph name="BEGIN_LINK"><resetlink></ph>reset sync<p
- <message name="IDS_MENU_SETTINGS" desc="Menu item for opening browser settings. [CHAR-LIMIT=27]">
- Settings
- </message>
- + <message name="IDS_MENU_EXIT" desc="Menu item for exit browser. [CHAR-LIMIT=27]">
- + Exit
- + </message>
- <message name="IDS_MENU_CLOSE_ALL_TABS" desc="Menu item for closing all open tabs. [CHAR-LIMIT=27]">
- Close all tabs
- </message>
- --
- 2.17.1
|