build-remove-calling-untrusted-hooks.patch 5.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179
  1. From: Jan Engelhardt <jengelh@inai.de>
  2. Date: Thu, 20 Apr 2017 16:25:49 +0200
  3. Subject: build: remove calling untrusted hooks
  4. Avoid downloading untrusted executables and wasting time with a
  5. sysroot.
  6. ---
  7. DEPS | 121 ++-----------------------------------------------------------------
  8. 1 file changed, 3 insertions(+), 118 deletions(-)
  9. diff --git a/DEPS b/DEPS
  10. --- a/DEPS
  11. +++ b/DEPS
  12. @@ -75,7 +75,7 @@ vars = {
  13. # Check out and download nacl by default. This can be disabled e.g. with
  14. # custom_vars.
  15. - 'checkout_nacl': True,
  16. + 'checkout_nacl': False,
  17. # By default, do not check out src-internal. This can be overridden e.g. with
  18. # custom_vars.
  19. @@ -99,8 +99,8 @@ vars = {
  20. # support for other platforms may be added in the future.
  21. 'checkout_openxr' : 'checkout_win',
  22. - 'checkout_traffic_annotation_tools': 'checkout_configuration != "small"',
  23. - 'checkout_instrumented_libraries': 'checkout_linux and checkout_configuration != "small"',
  24. + 'checkout_traffic_annotation_tools': False,
  25. + 'checkout_instrumented_libraries': False,
  26. # By default, do not check out WebKit for iOS, as it is not needed unless
  27. # running against ToT WebKit rather than system WebKit. This can be overridden
  28. @@ -3055,49 +3055,6 @@ hooks = [
  29. ],
  30. },
  31. {
  32. - 'name': 'sysroot_arm',
  33. - 'pattern': '.',
  34. - 'condition': 'checkout_linux and checkout_arm',
  35. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  36. - '--arch=arm'],
  37. - },
  38. - {
  39. - 'name': 'sysroot_arm64',
  40. - 'pattern': '.',
  41. - 'condition': 'checkout_linux and checkout_arm64',
  42. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  43. - '--arch=arm64'],
  44. - },
  45. - {
  46. - 'name': 'sysroot_x86',
  47. - 'pattern': '.',
  48. - 'condition': 'checkout_linux and (checkout_x86 or checkout_x64)',
  49. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  50. - '--arch=x86'],
  51. - },
  52. - {
  53. - 'name': 'sysroot_mips',
  54. - 'pattern': '.',
  55. - 'condition': 'checkout_linux and checkout_mips',
  56. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  57. - '--arch=mips'],
  58. - },
  59. - {
  60. - 'name': 'sysroot_mips64',
  61. - 'pattern': '.',
  62. - 'condition': 'checkout_linux and checkout_mips64',
  63. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  64. - '--arch=mips64el'],
  65. - },
  66. -
  67. - {
  68. - 'name': 'sysroot_x64',
  69. - 'pattern': '.',
  70. - 'condition': 'checkout_linux and checkout_x64',
  71. - 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
  72. - '--arch=x64'],
  73. - },
  74. - {
  75. # Case-insensitivity for the Win SDK. Must run before win_toolchain below.
  76. 'name': 'ciopfs_linux',
  77. 'pattern': '.',
  78. @@ -3124,43 +3081,6 @@ hooks = [
  79. 'condition': 'checkout_mac',
  80. 'action': ['python', 'src/build/mac_toolchain.py'],
  81. },
  82. - # Pull binutils for linux, enabled debug fission for faster linking /
  83. - # debugging when used with clang on Ubuntu Precise.
  84. - # https://code.google.com/p/chromium/issues/detail?id=352046
  85. - {
  86. - 'name': 'binutils',
  87. - 'pattern': 'src/third_party/binutils',
  88. - 'condition': 'host_os == "linux" and host_cpu != "mips64"',
  89. - 'action': [
  90. - 'python',
  91. - 'src/third_party/binutils/download.py',
  92. - ],
  93. - },
  94. - {
  95. - # Update the prebuilt clang toolchain.
  96. - # Note: On Win, this should run after win_toolchain, as it may use it.
  97. - 'name': 'clang',
  98. - 'pattern': '.',
  99. - 'condition': 'not llvm_force_head_revision',
  100. - 'action': ['python', 'src/tools/clang/scripts/update.py'],
  101. - },
  102. - {
  103. - # Build the clang toolchain from tip-of-tree.
  104. - # Note: On Win, this should run after win_toolchain, as it may use it.
  105. - 'name': 'clang_tot',
  106. - 'pattern': '.',
  107. - 'condition': 'llvm_force_head_revision',
  108. - 'action': ['python', 'src/tools/clang/scripts/build.py',
  109. - '--llvm-force-head-revision',
  110. - '--with-android={checkout_android}'],
  111. - },
  112. - {
  113. - # This is supposed to support the same set of platforms as 'clang' above.
  114. - 'name': 'clang_coverage',
  115. - 'pattern': '.',
  116. - 'condition': 'checkout_clang_coverage_tools',
  117. - 'action': ['python', 'src/tools/code_coverage/update_clang_coverage_tools.py'],
  118. - },
  119. {
  120. # Mac doesn't use lld so it's not included in the default clang bundle
  121. # there. lld is however needed in win and Fuchsia cross builds, so
  122. @@ -3220,18 +3140,6 @@ hooks = [
  123. '-s', 'src/buildtools/mac/clang-format.sha1',
  124. ],
  125. },
  126. - {
  127. - 'name': 'clang_format_linux',
  128. - 'pattern': '.',
  129. - 'condition': 'host_os == "linux"',
  130. - 'action': [ 'python',
  131. - 'src/third_party/depot_tools/download_from_google_storage.py',
  132. - '--no_resume',
  133. - '--no_auth',
  134. - '--bucket', 'chromium-clang-format',
  135. - '-s', 'src/buildtools/linux64/clang-format.sha1',
  136. - ],
  137. - },
  138. # Pull rc binaries using checked-in hashes.
  139. {
  140. 'name': 'rc_win',
  141. @@ -3257,29 +3165,6 @@ hooks = [
  142. '-s', 'src/build/toolchain/win/rc/mac/rc.sha1',
  143. ],
  144. },
  145. - {
  146. - 'name': 'rc_linux',
  147. - 'pattern': '.',
  148. - 'condition': 'checkout_win and host_os == "linux"',
  149. - 'action': [ 'python',
  150. - 'src/third_party/depot_tools/download_from_google_storage.py',
  151. - '--no_resume',
  152. - '--no_auth',
  153. - '--bucket', 'chromium-browser-clang/rc',
  154. - '-s', 'src/build/toolchain/win/rc/linux64/rc.sha1',
  155. - ]
  156. - },
  157. - {
  158. - 'name': 'test_fonts',
  159. - 'pattern': '.',
  160. - 'action': [ 'download_from_google_storage',
  161. - '--no_resume',
  162. - '--extract',
  163. - '--no_auth',
  164. - '--bucket', 'chromium-fonts',
  165. - '-s', 'src/third_party/test_fonts/test_fonts.tar.gz.sha1',
  166. - ],
  167. - },
  168. # Pull order files for the win/clang build.
  169. {
  170. 'name': 'orderfiles_win',
  171. --
  172. 2.11.0