Do-not-record-UMA-for-network-errors.patch 1.3 KB

1234567891011121314151617181920212223242526272829303132333435363738
  1. From: csagan5 <32685696+csagan5@users.noreply.github.com>
  2. Date: Sat, 27 Jul 2019 11:19:53 +0200
  3. Subject: Do not record UMA for network errors
  4. ---
  5. services/network/network_context.cc | 17 -----------------
  6. 1 file changed, 17 deletions(-)
  7. diff --git a/services/network/network_context.cc b/services/network/network_context.cc
  8. --- a/services/network/network_context.cc
  9. +++ b/services/network/network_context.cc
  10. @@ -393,23 +393,6 @@ class NetworkContext::ContextNetworkDelegate
  11. started);
  12. }
  13. - // Record network errors that HTTP requests complete with, including OK and
  14. - // ABORTED.
  15. - // TODO(mmenke): Seems like this really should be looking at HTTPS requests,
  16. - // too.
  17. - // TODO(mmenke): We should remove the main frame case from here, and move it
  18. - // into the consumer - the network service shouldn't know what a main frame
  19. - // is.
  20. - if (request->url().SchemeIs("http")) {
  21. - base::UmaHistogramSparse("Net.HttpRequestCompletionErrorCodes",
  22. - -net_error);
  23. -
  24. - if (request->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) {
  25. - base::UmaHistogramSparse(
  26. - "Net.HttpRequestCompletionErrorCodes.MainFrame", -net_error);
  27. - }
  28. - }
  29. -
  30. ForwardProxyErrors(net_error);
  31. }
  32. --
  33. 2.11.0