From: csagan5 <32685696+csagan5@users.noreply.github.com> Date: Sat, 23 Jan 2021 17:47:21 +0100 Subject: Revert "flags: remove num-raster-threads" This reverts commit 2a51528a1737e9038f7f96f29403032a6a845a25. --- chrome/browser/about_flags.cc | 12 ++++++++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 8 ++++++++ chrome/browser/flag_descriptions.h | 7 +++++++ 4 files changed, 32 insertions(+) diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -300,6 +300,15 @@ const FeatureEntry::Choice kOverlayStrategiesChoices[] = { "single-fullscreen,single-on-top,underlay"}, }; +const FeatureEntry::Choice kNumRasterThreadsChoices[] = { + {flags_ui::kGenericExperimentChoiceDefault, "", ""}, + {flag_descriptions::kNumRasterThreadsOne, switches::kNumRasterThreads, "1"}, + {flag_descriptions::kNumRasterThreadsTwo, switches::kNumRasterThreads, "2"}, + {flag_descriptions::kNumRasterThreadsThree, switches::kNumRasterThreads, + "3"}, + {flag_descriptions::kNumRasterThreadsFour, switches::kNumRasterThreads, + "4"}}; + const FeatureEntry::Choice kTouchTextSelectionStrategyChoices[] = { {flags_ui::kGenericExperimentChoiceDefault, "", ""}, {flag_descriptions::kTouchSelectionStrategyCharacter, @@ -3364,6 +3373,9 @@ const FeatureEntry kFeatureEntries[] = { feature_engagement::kIPHDemoMode, feature_engagement::kIPHDemoModeChoiceVariations, "IPH_DemoMode")}, + {"num-raster-threads", flag_descriptions::kNumRasterThreadsName, + flag_descriptions::kNumRasterThreadsDescription, kOsAll, + MULTI_VALUE_TYPE(kNumRasterThreadsChoices)}, {"disable-threaded-scrolling", flag_descriptions::kThreadedScrollingName, flag_descriptions::kThreadedScrollingDescription, kOsAll, SINGLE_DISABLE_VALUE_TYPE(blink::switches::kDisableThreadedScrolling)}, diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json --- a/chrome/browser/flag-metadata.json +++ b/chrome/browser/flag-metadata.json @@ -3629,6 +3629,11 @@ ], "expiry_milestone": 95 }, + { + "name": "num-raster-threads", + // "owners": [ "your-team" ], + "expiry_milestone": -1 + }, { "name": "minutes-delay-to-restore-gaia-cookies-if-deleted", "owners": ["fernandex", "chrome-signin-team"], diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc @@ -1629,6 +1629,14 @@ const char kUseMultiloginEndpointName[] = "Use Multilogin endpoint."; const char kUseMultiloginEndpointDescription[] = "Use Gaia OAuth multilogin for identity consistency."; +const char kNumRasterThreadsName[] = "Number of raster threads"; +const char kNumRasterThreadsDescription[] = + "Specify the number of raster threads."; +const char kNumRasterThreadsOne[] = "1"; +const char kNumRasterThreadsTwo[] = "2"; +const char kNumRasterThreadsThree[] = "3"; +const char kNumRasterThreadsFour[] = "4"; + const char kOmniboxAdaptiveSuggestionsCountName[] = "Adaptive Omnibox Suggestions count"; const char kOmniboxAdaptiveSuggestionsCountDescription[] = diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h --- a/chrome/browser/flag_descriptions.h +++ b/chrome/browser/flag_descriptions.h @@ -966,6 +966,13 @@ extern const char kNotificationsSystemFlagDescription[]; extern const char kUseMultiloginEndpointName[]; extern const char kUseMultiloginEndpointDescription[]; +extern const char kNumRasterThreadsName[]; +extern const char kNumRasterThreadsDescription[]; +extern const char kNumRasterThreadsOne[]; +extern const char kNumRasterThreadsTwo[]; +extern const char kNumRasterThreadsThree[]; +extern const char kNumRasterThreadsFour[]; + extern const char kOmniboxAdaptiveSuggestionsCountName[]; extern const char kOmniboxAdaptiveSuggestionsCountDescription[]; -- 2.17.1