Release 87.0.4280.106

CHANGELOG.md

@@ -1,3 +1,10 @@
+# 87.0.4280.106
+* enable SplitCacheByNetworkIsolationKey (fixes https://github.com/bromite/bromite/issues/836)
+* fix random timezone option (thanks to @uazo, fixes https://github.com/bromite/bromite/issues/828)
+* disable autofill server communication by default
+* ask permission to play protected media by default
+* disable SystemWebView variations support
+
 # 87.0.4280.81
 * fix text fragment not disabled by default, unexpire flag (fixes https://github.com/bromite/bromite/issues/803)
 * turn AImageReader off by default on ARM64 (fixes https://github.com/bromite/bromite/issues/814)

build/RELEASE

@@ -1 +1 @@
-87.0.4280.81
+87.0.4280.106

build/bromite_patches_list.txt

@@ -149,4 +149,8 @@ Restore-Simplified-NTP-launch.patch
 Revert-the-removal-of-an-option-to-block-autoplay.patch
 android-upstream-missed-manifest-changes-for-Q-R.patch
 Disable-text-fragments-by-default.patch
+disable-WebView-variations-support.patch
+disable-autofill-server-communication-by-default.patch
+ask-permission-to-play-protected-media-by-default.patch
+Enable-SplitCacheByNetworkIsolationKey.patch
 Automated-domain-substitution.patch

build/patches/Add-a-flag-to-allow-screenshots-in-Incognito-mode.patch

@@ -17,7 +17,7 @@ See also:
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -5169,6 +5169,12 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -5188,6 +5188,12 @@ const FeatureEntry kFeatureEntries[] = {
       kOsAll,
       FEATURE_VALUE_TYPE(features::kEnableAmbientAuthenticationInIncognito)},
  

build/patches/Add-flag-to-configure-maximum-connections-per-host.patch

@@ -31,7 +31,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
  // Ensure that all effective connection types returned by Network Quality
  // Estimator (NQE) are also exposed via flags.
  static_assert(net::EFFECTIVE_CONNECTION_TYPE_LAST + 2 ==
-@@ -3479,6 +3484,9 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -3495,6 +3500,9 @@ const FeatureEntry kFeatureEntries[] = {
       flag_descriptions::kAndroidPictureInPictureAPIName,
       flag_descriptions::kAndroidPictureInPictureAPIDescription, kOsAndroid,
       FEATURE_VALUE_TYPE(media::kPictureInPictureAPI)},

build/patches/Add-flag-to-control-video-playback-resume-feature.patch

@@ -13,7 +13,7 @@ Disable it by default on Android as it is everywhere else
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -2632,6 +2632,10 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -2648,6 +2648,10 @@ const FeatureEntry kFeatureEntries[] = {
       kOsAura,
       FEATURE_VALUE_TYPE(features::kOverlayScrollbarFlashWhenMouseEnter)},
  #endif  // USE_AURA

build/patches/Add-flag-to-disable-IPv6-probes.patch

@@ -16,7 +16,7 @@ Subject: Add flag to disable IPv6 probes
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -4423,6 +4423,11 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -4439,6 +4439,11 @@ const FeatureEntry kFeatureEntries[] = {
  #endif  // defined(OS_WIN) || defined(OS_MAC) || defined(OS_LINUX) ||
          // defined(OS_CHROMEOS)
  

build/patches/Add-flag-to-disable-WebGL.patch

@@ -11,7 +11,7 @@ Subject: Add flag to disable WebGL
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -2466,6 +2466,9 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -2482,6 +2482,9 @@ const FeatureEntry kFeatureEntries[] = {
       flag_descriptions::kAccelerated2dCanvasName,
       flag_descriptions::kAccelerated2dCanvasDescription, kOsAll,
       SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAccelerated2dCanvas)},

build/patches/Add-flags-to-disable-device-motion-orientation-APIs.patch

@@ -20,7 +20,7 @@ legacy acceleration events.
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -2685,6 +2685,12 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -2701,6 +2701,12 @@ const FeatureEntry kFeatureEntries[] = {
      {"enable-gpu-rasterization", flag_descriptions::kGpuRasterizationName,
       flag_descriptions::kGpuRasterizationDescription, kOsAll,
       MULTI_VALUE_TYPE(kEnableGpuRasterizationChoices)},

build/patches/Automated-domain-substitution.patch

@@ -1021,7 +1021,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
  
  const FeatureEntry::Choice kPassiveListenersChoices[] = {
      {flags_ui::kGenericExperimentChoiceDefault, "", ""},
-@@ -3308,7 +3308,7 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -3324,7 +3324,7 @@ const FeatureEntry kFeatureEntries[] = {
       flag_descriptions::kSyncSandboxDescription, kOsAll,
       SINGLE_VALUE_TYPE_AND_VALUE(
           switches::kSyncServiceURL,
@@ -1030,7 +1030,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
  #if !defined(OS_ANDROID)
      {"load-media-router-component-extension",
       flag_descriptions::kLoadMediaRouterComponentExtensionName,
-@@ -3558,7 +3558,7 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -3574,7 +3574,7 @@ const FeatureEntry kFeatureEntries[] = {
       flag_descriptions::kSetMarketUrlForTestingName,
       flag_descriptions::kSetMarketUrlForTestingDescription, kOsAndroid,
       SINGLE_VALUE_TYPE_AND_VALUE(switches::kMarketUrlForTesting,

build/patches/Disable-safe-browsing.patch

@@ -451,7 +451,7 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -2076,7 +2076,7 @@ const FeatureEntry::FeatureParam
+@@ -2092,7 +2092,7 @@ const FeatureEntry::FeatureParam
          {QuietNotificationPermissionUiConfig::kEnableAbusiveRequestWarning,
           "true"},
          {QuietNotificationPermissionUiConfig::kEnableCrowdDenyTriggering,

build/patches/Disable-text-fragments-by-default.patch

@@ -17,7 +17,7 @@ Revert "[Text Fragment] Unflag fragment directive removal."
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -5239,6 +5239,7 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -5258,6 +5258,7 @@ const FeatureEntry kFeatureEntries[] = {
       flag_descriptions::kEnableCSSOMViewScrollCoordinatesDescription, kOsAll,
       FEATURE_VALUE_TYPE(blink::features::kCSSOMViewScrollCoordinates)},
  

build/patches/Enable-SplitCacheByNetworkIsolationKey.patch

@@ -0,0 +1,23 @@
+From: csagan5 <32685696+csagan5@users.noreply.github.com>
+Date: Thu, 10 Dec 2020 21:52:35 +0100
+Subject: Enable SplitCacheByNetworkIsolationKey
+
+---
+ net/base/features.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/net/base/features.cc b/net/base/features.cc
+--- a/net/base/features.cc
++++ b/net/base/features.cc
+@@ -61,7 +61,7 @@ const base::Feature kNetworkQualityEstimator{"NetworkQualityEstimator",
+                                              base::FEATURE_DISABLED_BY_DEFAULT};
+ 
+ const base::Feature kSplitCacheByNetworkIsolationKey{
+-    "SplitCacheByNetworkIsolationKey", base::FEATURE_DISABLED_BY_DEFAULT};
++    "SplitCacheByNetworkIsolationKey", base::FEATURE_ENABLED_BY_DEFAULT};
+ 
+ const base::Feature kSplitHostCacheByNetworkIsolationKey{
+     "SplitHostCacheByNetworkIsolationKey", base::FEATURE_DISABLED_BY_DEFAULT};
+-- 
+2.17.1
+

build/patches/Enable-legacy-TLS-interstitital-warning.patch

@@ -15,7 +15,7 @@ Expose show-legacy-tls-warnings flag on Android as well
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -6026,11 +6026,9 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -6045,11 +6045,9 @@ const FeatureEntry kFeatureEntries[] = {
       FEATURE_VALUE_TYPE(features::kElasticOverscrollWin)},
  #endif
  

build/patches/Multiple-fingerprinting-mitigations.patch

@@ -74,7 +74,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
  #include "storage/browser/quota/quota_features.h"
  #include "third_party/blink/public/common/experiments/memory_ablation_experiment.h"
  #include "third_party/blink/public/common/features.h"
-@@ -2507,6 +2508,18 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -2523,6 +2524,18 @@ const FeatureEntry kFeatureEntries[] = {
      {"enable-webrtc-srtp-aes-gcm", flag_descriptions::kWebrtcSrtpAesGcmName,
       flag_descriptions::kWebrtcSrtpAesGcmDescription, kOsAll,
       SINGLE_VALUE_TYPE(switches::kEnableWebRtcSrtpAesGcm)},

build/patches/Restore-Search-Ready-Omnibox-flag.patch

@@ -54,7 +54,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggest
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -3029,6 +3029,9 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -3045,6 +3045,9 @@ const FeatureEntry kFeatureEntries[] = {
       flag_descriptions::kAndroidAutofillAccessibilityName,
       flag_descriptions::kAndroidAutofillAccessibilityDescription, kOsAndroid,
       FEATURE_VALUE_TYPE(features::kAndroidAutofillAccessibility)},

build/patches/Restore-Simplified-NTP-launch.patch

@@ -319,7 +319,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Sug
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -3548,6 +3548,9 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -3564,6 +3564,9 @@ const FeatureEntry kFeatureEntries[] = {
       SINGLE_VALUE_TYPE_AND_VALUE(
           switches::kForceShowUpdateMenuItemCustomSummary,
           "Custom Summary")},
@@ -423,7 +423,7 @@ diff --git a/components/ntp_snippets/features.cc b/components/ntp_snippets/featu
 diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
 --- a/testing/variations/fieldtrial_testing_config.json
 +++ b/testing/variations/fieldtrial_testing_config.json
-@@ -6668,6 +6668,24 @@
+@@ -6669,6 +6669,24 @@
              ]
          }
      ],

build/patches/Revert-flags-remove-disable-pull-to-refresh-effect.patch

@@ -13,7 +13,7 @@ This reverts commit 4e598f38a0e6dd3dbede009c6a99b2a520a94e1f.
 diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 --- a/chrome/browser/about_flags.cc
 +++ b/chrome/browser/about_flags.cc
-@@ -3054,6 +3054,10 @@ const FeatureEntry kFeatureEntries[] = {
+@@ -3070,6 +3070,10 @@ const FeatureEntry kFeatureEntries[] = {
       SINGLE_VALUE_TYPE(switches::kHostedAppQuitNotification)},
  #endif  // OS_MAC
  #if defined(OS_ANDROID)

build/patches/Revert-the-removal-of-an-option-to-block-autoplay.patch

@@ -524,7 +524,7 @@ diff --git a/components/content_settings/core/common/content_settings_mojom_trai
 +         data.ReadAutoplayRules(&out->autoplay_rules) &&
           data.ReadPopupRedirectRules(&out->popup_redirect_rules) &&
           data.ReadMixedContentRules(&out->mixed_content_rules) &&
-          data.ReadTimezoneOverrideRules(&out->timezone_override_rules) && 
+          data.ReadTimezoneOverrideRules(&out->timezone_override_rules) &&
 diff --git a/components/content_settings/core/common/content_settings_mojom_traits.h b/components/content_settings/core/common/content_settings_mojom_traits.h
 --- a/components/content_settings/core/common/content_settings_mojom_traits.h
 +++ b/components/content_settings/core/common/content_settings_mojom_traits.h
@@ -543,7 +543,7 @@ diff --git a/components/content_settings/core/common/content_settings_mojom_trai
 diff --git a/components/content_settings/renderer/content_settings_agent_impl.cc b/components/content_settings/renderer/content_settings_agent_impl.cc
 --- a/components/content_settings/renderer/content_settings_agent_impl.cc
 +++ b/components/content_settings/renderer/content_settings_agent_impl.cc
-@@ -440,6 +440,17 @@ bool ContentSettingsAgentImpl::AllowRunningInsecureContent(
+@@ -441,6 +441,17 @@ bool ContentSettingsAgentImpl::AllowRunningInsecureContent(
    return false;
  }
  

build/patches/ask-permission-to-play-protected-media-by-default.patch

@@ -0,0 +1,31 @@
+From: Daniel Micay <danielmicay@gmail.com>
+Date: Tue, 1 Dec 2020 00:29:28 -0500
+Subject: ask permission to play protected media by default
+
+---
+ .../core/browser/content_settings_registry.cc            | 9 ---------
+ 1 file changed, 9 deletions(-)
+
+diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc
+--- a/components/content_settings/core/browser/content_settings_registry.cc
++++ b/components/content_settings/core/browser/content_settings_registry.cc
+@@ -78,16 +78,7 @@ std::set<ContentSetting> ValidSettings(ContentSetting setting1,
+ }
+ 
+ ContentSetting GetInitialDefaultContentSettingForProtectedMediaIdentifier() {
+-// On Android, the default value is ALLOW or ASK depending on whether per-origin
+-// provisioning is used (https://crbug.com/854737 and https://crbug.com/904883).
+-// On ChromeOS the default value is always ASK.
+-#if defined(OS_ANDROID)
+-  return media::MediaDrmBridge::IsPerOriginProvisioningSupported()
+-             ? CONTENT_SETTING_ALLOW
+-             : CONTENT_SETTING_ASK;
+-#else
+   return CONTENT_SETTING_ASK;
+-#endif  // defined(OS_ANDROID)
+ }
+ 
+ }  // namespace
+-- 
+2.17.1
+

build/patches/disable-WebView-variations-support.patch

@@ -0,0 +1,38 @@
+From: Daniel Micay <danielmicay@gmail.com>
+Date: Thu, 10 Dec 2020 10:09:18 -0500
+Subject: disable WebView variations support
+
+---
+ .../com/android/webview/chromium/WebViewChromiumAwInit.java   | 4 ----
+ .../webview/chromium/WebViewChromiumFactoryProvider.java      | 2 --
+ 2 files changed, 6 deletions(-)
+
+diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
+--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
++++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
+@@ -165,10 +165,6 @@ public class WebViewChromiumAwInit {
+ 
+             AwBrowserProcess.configureChildProcessLauncher();
+ 
+-            // finishVariationsInitLocked() must precede native initialization so the seed is
+-            // available when AwFeatureListCreator::SetUpFieldTrials() runs.
+-            finishVariationsInitLocked();
+-
+             AwBrowserProcess.start();
+             AwBrowserProcess.handleMinidumpsAndSetMetricsConsent(true /* updateMetricsConsent */);
+ 
+diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
+--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
++++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
+@@ -380,8 +380,6 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
+                 AwContentsStatics.logFlagOverridesWithNative(flagOverrides);
+             }
+ 
+-            mAwInit.startVariationsInit();
+-
+             mShouldDisableThreadChecking = shouldDisableThreadChecking(ctx);
+ 
+             setSingleton(this);
+-- 
+2.17.1
+

build/patches/disable-autofill-server-communication-by-default.patch

@@ -0,0 +1,23 @@
+From: Daniel Micay <danielmicay@gmail.com>
+Date: Tue, 1 Dec 2020 00:56:57 -0500
+Subject: disable autofill server communication by default
+
+---
+ components/autofill/core/common/autofill_features.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/components/autofill/core/common/autofill_features.cc b/components/autofill/core/common/autofill_features.cc
+--- a/components/autofill/core/common/autofill_features.cc
++++ b/components/autofill/core/common/autofill_features.cc
+@@ -240,7 +240,7 @@ const base::Feature kAutofillSectionUponRedundantNameInfo{
+ // "upload" resources.
+ // i.e., https://other.autofill.server:port/tbproxy/af/
+ const base::Feature kAutofillServerCommunication{
+-    "AutofillServerCommunication", base::FEATURE_ENABLED_BY_DEFAULT};
++    "AutofillServerCommunication", base::FEATURE_DISABLED_BY_DEFAULT};
+ 
+ // Controls attaching the autofill type predictions to their respective
+ // element in the DOM.
+-- 
+2.17.1
+

build/patches/ungoogled-chromium-Disable-translate-integration.patch

@@ -121,7 +121,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
 diff --git a/components/translate/core/browser/translate_manager.cc b/components/translate/core/browser/translate_manager.cc
 --- a/components/translate/core/browser/translate_manager.cc
 +++ b/components/translate/core/browser/translate_manager.cc
-@@ -736,8 +736,9 @@ void TranslateManager::FilterIsTranslatePossible(
+@@ -734,8 +734,9 @@ void TranslateManager::FilterIsTranslatePossible(
          TranslateBrowserMetrics::INITIATION_STATUS_NO_NETWORK);
    }