|
@@ -4,25 +4,39 @@ Subject: Disable signin and data saver preferences
|
|
|
|
|
|
Never show the data saver promo snackbar
|
|
|
---
|
|
|
- chrome/android/java/res/xml/main_preferences.xml | 9 ---
|
|
|
- .../browser/preferences/MainPreferences.java | 91 +---------------------
|
|
|
- 2 files changed, 2 insertions(+), 98 deletions(-)
|
|
|
+ chrome/android/java/res/xml/main_preferences.xml | 20 -----
|
|
|
+ .../android/java/res/xml/privacy_preferences.xml | 7 --
|
|
|
+ .../browser/preferences/MainPreferences.java | 92 +---------------------
|
|
|
+ .../preferences/privacy/PrivacyPreferences.java | 17 ----
|
|
|
+ .../java/strings/android_chrome_strings.grd | 6 --
|
|
|
+ 5 files changed, 1 insertion(+), 141 deletions(-)
|
|
|
|
|
|
diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
|
|
|
--- a/chrome/android/java/res/xml/main_preferences.xml
|
|
|
+++ b/chrome/android/java/res/xml/main_preferences.xml
|
|
|
-@@ -10,10 +10,6 @@
|
|
|
- android:key="account_section"
|
|
|
- android:order="0"
|
|
|
- android:title="@string/prefs_section_account"/>
|
|
|
+@@ -7,21 +7,6 @@
|
|
|
+ android:orderingFromXml="false">
|
|
|
+
|
|
|
+ <PreferenceCategory
|
|
|
+- android:key="account_section"
|
|
|
+- android:order="0"
|
|
|
+- android:title="@string/prefs_section_account"/>
|
|
|
- <org.chromium.chrome.browser.preferences.SignInPreference
|
|
|
- android:key="sign_in"
|
|
|
- android:order="1"
|
|
|
- android:title="@string/sign_in_to_chrome"/>
|
|
|
- <org.chromium.chrome.browser.preferences.ChromeBasePreference
|
|
|
- android:key="sync_and_services"
|
|
|
- android:order="2"
|
|
|
-@@ -96,11 +92,6 @@
|
|
|
+- <org.chromium.chrome.browser.preferences.ChromeBasePreference
|
|
|
+- android:key="sync_and_services"
|
|
|
+- android:order="2"
|
|
|
+- android:layout="@layout/account_management_account_row"
|
|
|
+- android:title="@string/prefs_sync_and_services"
|
|
|
+- android:fragment="org.chromium.chrome.browser.preferences.SyncAndServicesPreferences"/>
|
|
|
+-
|
|
|
+- <PreferenceCategory
|
|
|
+ android:key="basics_section"
|
|
|
+ android:order="3"
|
|
|
+ android:title="@string/prefs_section_basics"/>
|
|
|
+@@ -96,11 +81,6 @@
|
|
|
android:key="languages"
|
|
|
android:order="17"
|
|
|
android:title="@string/prefs_languages"/>
|
|
@@ -34,6 +48,21 @@ diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/j
|
|
|
<org.chromium.chrome.browser.preferences.ChromeBasePreference
|
|
|
android:fragment="org.chromium.chrome.browser.preferences.download.DownloadPreferences"
|
|
|
android:key="downloads"
|
|
|
+diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
|
|
+--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
|
|
++++ b/chrome/android/java/res/xml/privacy_preferences.xml
|
|
|
+@@ -55,11 +55,4 @@
|
|
|
+ android:title="@string/clear_browsing_data_title"
|
|
|
+ android:summary="@string/clear_browsing_data_summary"
|
|
|
+ android:fragment="org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataTabsFragment" />
|
|
|
+- <Preference
|
|
|
+- android:key="sync_and_services_link_divider"
|
|
|
+- android:layout="@layout/divider_preference"
|
|
|
+- android:selectable="false"/>
|
|
|
+- <org.chromium.chrome.browser.preferences.TextMessagePreference
|
|
|
+- android:key="sync_and_services_link"
|
|
|
+- tools:summary="@string/privacy_sync_and_services_link"/>
|
|
|
+ </PreferenceScreen>
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
|
|
@@ -54,20 +83,20 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
import org.chromium.chrome.browser.util.FeatureUtilities;
|
|
|
|
|
|
import java.util.HashMap;
|
|
|
-@@ -36,11 +32,8 @@ import java.util.Map;
|
|
|
+@@ -36,11 +32,7 @@ import java.util.Map;
|
|
|
* The main settings screen, shown when the user first opens Settings.
|
|
|
*/
|
|
|
public class MainPreferences extends PreferenceFragment
|
|
|
- implements TemplateUrlService.LoadListener, ProfileSyncService.SyncStateChangedListener,
|
|
|
- SigninManager.SignInStateObserver {
|
|
|
-+ implements TemplateUrlService.LoadListener {
|
|
|
- public static final String PREF_ACCOUNT_SECTION = "account_section";
|
|
|
+- public static final String PREF_ACCOUNT_SECTION = "account_section";
|
|
|
- public static final String PREF_SIGN_IN = "sign_in";
|
|
|
- public static final String PREF_SYNC_AND_SERVICES = "sync_and_services";
|
|
|
++ implements TemplateUrlService.LoadListener {
|
|
|
public static final String PREF_SEARCH_ENGINE = "search_engine";
|
|
|
public static final String PREF_SAVED_PASSWORDS = "saved_passwords";
|
|
|
public static final String PREF_CONTEXTUAL_SUGGESTIONS = "contextual_suggestions";
|
|
|
-@@ -60,7 +53,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -60,7 +52,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
|
|
|
private final ManagedPreferenceDelegate mManagedPreferenceDelegate;
|
|
|
private final Map<String, Preference> mAllPreferences = new HashMap<>();
|
|
@@ -75,7 +104,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
|
|
|
public MainPreferences() {
|
|
|
setHasOptionsMenu(true);
|
|
|
-@@ -76,33 +68,16 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -76,33 +67,16 @@ public class MainPreferences extends PreferenceFragment
|
|
|
@Override
|
|
|
public void onDestroy() {
|
|
|
super.onDestroy();
|
|
@@ -109,7 +138,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
}
|
|
|
|
|
|
@Override
|
|
|
-@@ -115,17 +90,11 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -115,17 +89,9 @@ public class MainPreferences extends PreferenceFragment
|
|
|
PreferenceUtils.addPreferencesFromResource(this, R.xml.main_preferences);
|
|
|
cachePreferences();
|
|
|
|
|
@@ -119,8 +148,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
- getPreferenceScreen().removePreference(findPreference(PREF_ACCOUNT_SECTION));
|
|
|
- getPreferenceScreen().removePreference(findPreference(PREF_SYNC_AND_SERVICES));
|
|
|
- }
|
|
|
-+ getPreferenceScreen().removePreference(findPreference(PREF_ACCOUNT_SECTION));
|
|
|
-
|
|
|
+-
|
|
|
updatePasswordsPreference();
|
|
|
|
|
|
setManagedPreferenceDelegateForPreference(PREF_SEARCH_ENGINE);
|
|
@@ -128,7 +156,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
|
|
|
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
|
|
|
// If we are on Android O+ the Notifications preference should lead to the Android
|
|
|
-@@ -189,7 +158,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -189,7 +155,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
Preference preference = getPreferenceScreen().getPreference(index);
|
|
|
mAllPreferences.put(preference.getKey(), preference);
|
|
|
}
|
|
@@ -136,7 +164,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
}
|
|
|
|
|
|
private void setManagedPreferenceDelegateForPreference(String key) {
|
|
|
-@@ -198,13 +166,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -198,13 +163,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
}
|
|
|
|
|
|
private void updatePreferences() {
|
|
@@ -150,7 +178,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
updateSearchEnginePreference();
|
|
|
|
|
|
Preference homepagePref = addPreferenceIfAbsent(PREF_HOMEPAGE);
|
|
|
-@@ -234,10 +195,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -234,10 +192,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
} else {
|
|
|
removePreferenceIfPresent(PREF_DEVELOPER);
|
|
|
}
|
|
@@ -161,7 +189,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
}
|
|
|
|
|
|
private Preference addPreferenceIfAbsent(String key) {
|
|
|
-@@ -251,15 +208,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -251,15 +205,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
if (preference != null) getPreferenceScreen().removePreference(preference);
|
|
|
}
|
|
|
|
|
@@ -177,7 +205,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
private void updateSearchEnginePreference() {
|
|
|
if (!TemplateUrlService.getInstance().isLoaded()) {
|
|
|
ChromeBasePreference searchEnginePref =
|
|
|
-@@ -291,28 +239,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -291,28 +236,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
pref.setSummary(getResources().getString(isOn ? R.string.text_on : R.string.text_off));
|
|
|
}
|
|
|
|
|
@@ -206,7 +234,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
// TemplateUrlService.LoadListener implementation.
|
|
|
@Override
|
|
|
public void onTemplateUrlServiceLoaded() {
|
|
|
-@@ -320,11 +246,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -320,11 +243,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
updateSearchEnginePreference();
|
|
|
}
|
|
|
|
|
@@ -218,7 +246,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
@VisibleForTesting
|
|
|
ManagedPreferenceDelegate getManagedPreferenceDelegateForTest() {
|
|
|
return mManagedPreferenceDelegate;
|
|
|
-@@ -334,9 +255,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -334,9 +252,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
return new ManagedPreferenceDelegate() {
|
|
|
@Override
|
|
|
public boolean isPreferenceControlledByPolicy(Preference preference) {
|
|
@@ -228,7 +256,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
if (PREF_SEARCH_ENGINE.equals(preference.getKey())) {
|
|
|
return TemplateUrlService.getInstance().isDefaultSearchManaged();
|
|
|
}
|
|
|
-@@ -345,11 +263,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
+@@ -345,11 +260,6 @@ public class MainPreferences extends PreferenceFragment
|
|
|
|
|
|
@Override
|
|
|
public boolean isPreferenceClickDisabledByPolicy(Preference preference) {
|
|
@@ -240,6 +268,73 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
if (PREF_SEARCH_ENGINE.equals(preference.getKey())) {
|
|
|
return TemplateUrlService.getInstance().isDefaultSearchManaged();
|
|
|
}
|
|
|
+diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
|
|
|
+--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
|
|
|
++++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
|
|
|
+@@ -27,7 +27,6 @@ import org.chromium.chrome.browser.preferences.Pref;
|
|
|
+ import org.chromium.chrome.browser.preferences.PrefServiceBridge;
|
|
|
+ import org.chromium.chrome.browser.preferences.PreferenceUtils;
|
|
|
+ import org.chromium.chrome.browser.preferences.PreferencesLauncher;
|
|
|
+-import org.chromium.chrome.browser.preferences.SyncAndServicesPreferences;
|
|
|
+ import org.chromium.chrome.browser.profiles.Profile;
|
|
|
+ import org.chromium.chrome.browser.usage_stats.UsageStatsConsentDialog;
|
|
|
+ import org.chromium.ui.text.NoUnderlineClickableSpan;
|
|
|
+@@ -49,9 +48,6 @@ public class PrivacyPreferences extends PreferenceFragment
|
|
|
+ private static final String PREF_DO_NOT_TRACK = "do_not_track";
|
|
|
+ private static final String PREF_USAGE_AND_CRASH_REPORTING = "usage_and_crash_reports";
|
|
|
+ private static final String PREF_CLEAR_BROWSING_DATA = "clear_browsing_data";
|
|
|
+- private static final String PREF_SYNC_AND_SERVICES_LINK_DIVIDER =
|
|
|
+- "sync_and_services_link_divider";
|
|
|
+- private static final String PREF_SYNC_AND_SERVICES_LINK = "sync_and_services_link";
|
|
|
+ private static final String PREF_USAGE_STATS = "usage_stats_reporting";
|
|
|
+
|
|
|
+ private ManagedPreferenceDelegate mManagedPreferenceDelegate;
|
|
|
+@@ -100,22 +96,9 @@ public class PrivacyPreferences extends PreferenceFragment
|
|
|
+ networkPredictionPref.setOrder(canMakePaymentPref.getOrder());
|
|
|
+ preferenceScreen.addPreference(networkPredictionPref);
|
|
|
+
|
|
|
+- Preference syncAndServicesLink = findPreference(PREF_SYNC_AND_SERVICES_LINK);
|
|
|
+- NoUnderlineClickableSpan linkSpan =
|
|
|
+- new NoUnderlineClickableSpan(getResources(), view -> {
|
|
|
+- PreferencesLauncher.launchSettingsPage(getActivity(),
|
|
|
+- SyncAndServicesPreferences.class,
|
|
|
+- SyncAndServicesPreferences.createArguments(false));
|
|
|
+- });
|
|
|
+- syncAndServicesLink.setSummary(
|
|
|
+- SpanApplier.applySpans(getString(R.string.privacy_sync_and_services_link),
|
|
|
+- new SpanApplier.SpanInfo("<link>", "</link>", linkSpan)));
|
|
|
+-
|
|
|
+ updateSummaries();
|
|
|
+ return;
|
|
|
+ }
|
|
|
+- preferenceScreen.removePreference(findPreference(PREF_SYNC_AND_SERVICES_LINK_DIVIDER));
|
|
|
+- preferenceScreen.removePreference(findPreference(PREF_SYNC_AND_SERVICES_LINK));
|
|
|
+
|
|
|
+ ChromeBaseCheckBoxPreference navigationErrorPref =
|
|
|
+ (ChromeBaseCheckBoxPreference) findPreference(PREF_NAVIGATION_ERROR);
|
|
|
+diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
+--- a/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
++++ b/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
+@@ -315,9 +315,6 @@ CHAR-LIMIT guidelines:
|
|
|
+ </message>
|
|
|
+
|
|
|
+ <!-- Sign-in, sync and personalization preferences -->
|
|
|
+- <message name="IDS_PREFS_SECTION_ACCOUNT" desc="Title for the group of account-related entries in Settings. [CHAR-LIMIT=32]">
|
|
|
+- Account
|
|
|
+- </message>
|
|
|
+ <message name="IDS_SIGN_IN_TO_CHROME" desc="Title for the button to sign in to Chrome using one's Google account. [CHAR-LIMIT=27]">
|
|
|
+ Sign in to Chrome
|
|
|
+ </message>
|
|
|
+@@ -400,9 +397,6 @@ CHAR-LIMIT guidelines:
|
|
|
+ <message name="IDS_URL_KEYED_ANONYMIZED_DATA_SUMMARY" desc="Summary for a checkbox in Settings that controls non-personalized URL collection and informs the user about the data shared by this feature.">
|
|
|
+ Sends URLs of pages you visit to Google
|
|
|
+ </message>
|
|
|
+- <message name="IDS_PRIVACY_SYNC_AND_SERVICES_LINK" desc="The text for Privacy preferences that is shown after all preference rows.">
|
|
|
+- For more settings that relate to privacy, security, and data collection, see <ph name="BEGIN_LINK"><link></ph>Sync and Google services<ph name="END_LINK"></link></ph>
|
|
|
+- </message>
|
|
|
+ <message name="IDS_USAGE_AND_CRASH_REPORTS_TITLE" desc="Title for a preference that enables sending usage statistics and crash reports.">
|
|
|
+ Help improve Chrome's features and performance
|
|
|
+ </message>
|
|
|
--
|
|
|
2.11.0
|
|
|
|