|
@@ -1780,7 +1780,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
return results
|
|
return results
|
|
|
|
|
|
|
|
|
|
-@@ -2965,7 +2965,7 @@ def CheckSecurityOwners(input_api, output_api):
|
|
|
|
|
|
+@@ -2967,7 +2967,7 @@ def CheckSecurityOwners(input_api, output_api):
|
|
if to_check:
|
|
if to_check:
|
|
# If there are any OWNERS files to check, there are IPC-related changes in
|
|
# If there are any OWNERS files to check, there are IPC-related changes in
|
|
# this CL. Auto-CC the review list.
|
|
# this CL. Auto-CC the review list.
|
|
@@ -1789,7 +1789,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
|
|
|
|
# Go through the OWNERS files to check, filtering out rules that are already
|
|
# Go through the OWNERS files to check, filtering out rules that are already
|
|
# present in that OWNERS file.
|
|
# present in that OWNERS file.
|
|
-@@ -3263,7 +3263,7 @@ def _CheckAndroidToastUsage(input_api, output_api):
|
|
|
|
|
|
+@@ -3265,7 +3265,7 @@ def _CheckAndroidToastUsage(input_api, output_api):
|
|
'android.widget.Toast usage is detected. Android toasts use hardware'
|
|
'android.widget.Toast usage is detected. Android toasts use hardware'
|
|
' acceleration, and can be\ncostly on low-end devices. Please use'
|
|
' acceleration, and can be\ncostly on low-end devices. Please use'
|
|
' org.chromium.ui.widget.Toast instead.\n'
|
|
' org.chromium.ui.widget.Toast instead.\n'
|
|
@@ -1798,7 +1798,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
errors))
|
|
errors))
|
|
|
|
|
|
return results
|
|
return results
|
|
-@@ -3397,7 +3397,7 @@ def _CheckAndroidTestJUnitFrameworkImport(input_api, output_api):
|
|
|
|
|
|
+@@ -3399,7 +3399,7 @@ def _CheckAndroidTestJUnitFrameworkImport(input_api, output_api):
|
|
if errors:
|
|
if errors:
|
|
results.append(output_api.PresubmitError(
|
|
results.append(output_api.PresubmitError(
|
|
'APIs from junit.framework.* are deprecated, please use JUnit4 framework'
|
|
'APIs from junit.framework.* are deprecated, please use JUnit4 framework'
|
|
@@ -1807,7 +1807,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
' if you have any question.', errors))
|
|
' if you have any question.', errors))
|
|
return results
|
|
return results
|
|
|
|
|
|
-@@ -3428,7 +3428,7 @@ def _CheckAndroidTestJUnitInheritance(input_api, output_api):
|
|
|
|
|
|
+@@ -3430,7 +3430,7 @@ def _CheckAndroidTestJUnitInheritance(input_api, output_api):
|
|
results.append(output_api.PresubmitPromptWarning(
|
|
results.append(output_api.PresubmitPromptWarning(
|
|
'The newly created files include Test classes that inherits from base'
|
|
'The newly created files include Test classes that inherits from base'
|
|
' class. Please do not use inheritance in JUnit4 tests or add new'
|
|
' class. Please do not use inheritance in JUnit4 tests or add new'
|
|
@@ -1816,7 +1816,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
' questions.', errors))
|
|
' questions.', errors))
|
|
return results
|
|
return results
|
|
|
|
|
|
-@@ -3452,7 +3452,7 @@ def _CheckAndroidTestAnnotationUsage(input_api, output_api):
|
|
|
|
|
|
+@@ -3454,7 +3454,7 @@ def _CheckAndroidTestAnnotationUsage(input_api, output_api):
|
|
'Annotations in android.test.suitebuilder.annotation have been'
|
|
'Annotations in android.test.suitebuilder.annotation have been'
|
|
' deprecated since API level 24. Please use android.support.test.filters'
|
|
' deprecated since API level 24. Please use android.support.test.filters'
|
|
' from //third_party/android_support_test_runner:runner_java instead.'
|
|
' from //third_party/android_support_test_runner:runner_java instead.'
|
|
@@ -1825,7 +1825,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
return results
|
|
return results
|
|
|
|
|
|
|
|
|
|
-@@ -3472,7 +3472,7 @@ def _CheckAndroidNewMdpiAssetLocation(input_api, output_api):
|
|
|
|
|
|
+@@ -3474,7 +3474,7 @@ def _CheckAndroidNewMdpiAssetLocation(input_api, output_api):
|
|
'MDPI assets should be placed in /res/drawable-mdpi/ or '
|
|
'MDPI assets should be placed in /res/drawable-mdpi/ or '
|
|
'/res/drawable-ldrtl-mdpi/\ninstead of /res/drawable/ and'
|
|
'/res/drawable-ldrtl-mdpi/\ninstead of /res/drawable/ and'
|
|
'/res/drawable-ldrtl/.\n'
|
|
'/res/drawable-ldrtl/.\n'
|
|
@@ -1834,7 +1834,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
return results
|
|
return results
|
|
|
|
|
|
|
|
|
|
-@@ -4007,7 +4007,7 @@ def CheckGnGlobForward(input_api, output_api):
|
|
|
|
|
|
+@@ -4009,7 +4009,7 @@ def CheckGnGlobForward(input_api, output_api):
|
|
long_text=('The variables "visibilty" and "test_only" should be '
|
|
long_text=('The variables "visibilty" and "test_only" should be '
|
|
'explicitly listed in forward_variables_from(). For more '
|
|
'explicitly listed in forward_variables_from(). For more '
|
|
'details, see:\n'
|
|
'details, see:\n'
|
|
@@ -1843,7 +1843,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
'build/docs/writing_gn_templates.md'
|
|
'build/docs/writing_gn_templates.md'
|
|
'#Using-forward_variables_from'))]
|
|
'#Using-forward_variables_from'))]
|
|
return []
|
|
return []
|
|
-@@ -4210,7 +4210,7 @@ def CheckFuzzTargetsOnUpload(input_api, output_api):
|
|
|
|
|
|
+@@ -4212,7 +4212,7 @@ def CheckFuzzTargetsOnUpload(input_api, output_api):
|
|
'LLVMFuzzerInitialize should not be used, unless your fuzz target needs '
|
|
'LLVMFuzzerInitialize should not be used, unless your fuzz target needs '
|
|
'to access command line arguments passed to the fuzzer. Instead, prefer '
|
|
'to access command line arguments passed to the fuzzer. Instead, prefer '
|
|
'static initialization and shared resources as documented in '
|
|
'static initialization and shared resources as documented in '
|
|
@@ -1852,7 +1852,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
'libfuzzer/efficient_fuzzing.md#simplifying-initialization_cleanup.\n' % (
|
|
'libfuzzer/efficient_fuzzing.md#simplifying-initialization_cleanup.\n' % (
|
|
', '.join(EXPORTED_SYMBOLS), REQUIRED_HEADER)
|
|
', '.join(EXPORTED_SYMBOLS), REQUIRED_HEADER)
|
|
)
|
|
)
|
|
-@@ -4245,7 +4245,7 @@ def _CheckNewImagesWarning(input_api, output_api):
|
|
|
|
|
|
+@@ -4247,7 +4247,7 @@ def _CheckNewImagesWarning(input_api, output_api):
|
|
errors.append(output_api.PresubmitPromptWarning(
|
|
errors.append(output_api.PresubmitPromptWarning(
|
|
'It looks like you are trying to commit some images. If these are '
|
|
'It looks like you are trying to commit some images. If these are '
|
|
'non-test-only images, please make sure to read and apply the tips in '
|
|
'non-test-only images, please make sure to read and apply the tips in '
|
|
@@ -1861,7 +1861,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
'binary_size/optimization_advice.md#optimizing-images\nThis check is '
|
|
'binary_size/optimization_advice.md#optimizing-images\nThis check is '
|
|
'FYI only and will not block your CL on the CQ.', image_paths))
|
|
'FYI only and will not block your CL on the CQ.', image_paths))
|
|
return errors
|
|
return errors
|
|
-@@ -4529,7 +4529,7 @@ def CheckForInvalidIfDefinedMacros(input_api, output_api):
|
|
|
|
|
|
+@@ -4531,7 +4531,7 @@ def CheckForInvalidIfDefinedMacros(input_api, output_api):
|
|
|
|
|
|
def CheckForIPCRules(input_api, output_api):
|
|
def CheckForIPCRules(input_api, output_api):
|
|
"""Check for same IPC rules described in
|
|
"""Check for same IPC rules described in
|
|
@@ -1870,7 +1870,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
"""
|
|
"""
|
|
base_pattern = r'IPC_ENUM_TRAITS\('
|
|
base_pattern = r'IPC_ENUM_TRAITS\('
|
|
inclusion_pattern = input_api.re.compile(r'(%s)' % base_pattern)
|
|
inclusion_pattern = input_api.re.compile(r'(%s)' % base_pattern)
|
|
-@@ -4773,7 +4773,7 @@ def CheckChangeOnCommit(input_api, output_api):
|
|
|
|
|
|
+@@ -4775,7 +4775,7 @@ def CheckChangeOnCommit(input_api, output_api):
|
|
results.extend(input_api.canned_checks.CheckTreeIsOpen(
|
|
results.extend(input_api.canned_checks.CheckTreeIsOpen(
|
|
input_api,
|
|
input_api,
|
|
output_api,
|
|
output_api,
|
|
@@ -1879,7 +1879,7 @@ diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
|
|
|
|
results.extend(
|
|
results.extend(
|
|
input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
|
|
input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
|
|
-@@ -5105,7 +5105,7 @@ def CheckStrings(input_api, output_api):
|
|
|
|
|
|
+@@ -5107,7 +5107,7 @@ def CheckStrings(input_api, output_api):
|
|
if icu_syntax_errors:
|
|
if icu_syntax_errors:
|
|
results.append(output_api.PresubmitPromptWarning(
|
|
results.append(output_api.PresubmitPromptWarning(
|
|
'ICU syntax errors were found in the following strings (problems or '
|
|
'ICU syntax errors were found in the following strings (problems or '
|
|
@@ -4292,7 +4292,7 @@ diff --git a/chrome/browser/browser_switcher/browser_switcher_service.cc b/chrom
|
|
diff --git a/chrome/browser/cart/cart_service.cc b/chrome/browser/cart/cart_service.cc
|
|
diff --git a/chrome/browser/cart/cart_service.cc b/chrome/browser/cart/cart_service.cc
|
|
--- a/chrome/browser/cart/cart_service.cc
|
|
--- a/chrome/browser/cart/cart_service.cc
|
|
+++ b/chrome/browser/cart/cart_service.cc
|
|
+++ b/chrome/browser/cart/cart_service.cc
|
|
-@@ -218,23 +218,23 @@ void CartService::AddCartsWithFakeData() {
|
|
|
|
|
|
+@@ -219,23 +219,23 @@ void CartService::AddCartsWithFakeData() {
|
|
// Polulate and add some carts with fake data.
|
|
// Polulate and add some carts with fake data.
|
|
double time_now = base::Time::Now().ToDoubleT();
|
|
double time_now = base::Time::Now().ToDoubleT();
|
|
cart_db::ChromeCartContentProto dummy_proto1;
|
|
cart_db::ChromeCartContentProto dummy_proto1;
|
|
@@ -4715,7 +4715,7 @@ diff --git a/chrome/browser/chromeos/login/screens/recommend_apps/recommend_apps
|
|
diff --git a/chrome/browser/chromeos/login/session/user_session_manager.cc b/chrome/browser/chromeos/login/session/user_session_manager.cc
|
|
diff --git a/chrome/browser/chromeos/login/session/user_session_manager.cc b/chrome/browser/chromeos/login/session/user_session_manager.cc
|
|
--- a/chrome/browser/chromeos/login/session/user_session_manager.cc
|
|
--- a/chrome/browser/chromeos/login/session/user_session_manager.cc
|
|
+++ b/chrome/browser/chromeos/login/session/user_session_manager.cc
|
|
+++ b/chrome/browser/chromeos/login/session/user_session_manager.cc
|
|
-@@ -1214,7 +1214,7 @@ void ShowSupervisedUserDeprecationNotification(Profile* profile,
|
|
|
|
|
|
+@@ -1215,7 +1215,7 @@ void ShowSupervisedUserDeprecationNotification(Profile* profile,
|
|
|
|
|
|
NavigateParams params(
|
|
NavigateParams params(
|
|
profile,
|
|
profile,
|
|
@@ -22240,7 +22240,7 @@ diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/
|
|
diff --git a/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm b/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm
|
|
diff --git a/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm b/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm
|
|
--- a/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm
|
|
--- a/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm
|
|
+++ b/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm
|
|
+++ b/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm
|
|
-@@ -491,7 +491,7 @@ const char* const kGeolocationAuthorizationActionNewUser =
|
|
|
|
|
|
+@@ -229,7 +229,7 @@ const char* const kGeolocationAuthorizationActionNewUser =
|
|
}
|
|
}
|
|
|
|
|
|
- (BOOL)URLIsAuthorizationPromptingURL:(const GURL&)url {
|
|
- (BOOL)URLIsAuthorizationPromptingURL:(const GURL&)url {
|
|
@@ -24355,7 +24355,7 @@ diff --git a/remoting/host/it2me/it2me_native_messaging_host.cc b/remoting/host/
|
|
diff --git a/remoting/host/linux/linux_me2me_host.py b/remoting/host/linux/linux_me2me_host.py
|
|
diff --git a/remoting/host/linux/linux_me2me_host.py b/remoting/host/linux/linux_me2me_host.py
|
|
--- a/remoting/host/linux/linux_me2me_host.py
|
|
--- a/remoting/host/linux/linux_me2me_host.py
|
|
+++ b/remoting/host/linux/linux_me2me_host.py
|
|
+++ b/remoting/host/linux/linux_me2me_host.py
|
|
-@@ -1474,7 +1474,7 @@ def watch_for_resolution_changes(initial_size):
|
|
|
|
|
|
+@@ -1485,7 +1485,7 @@ def watch_for_resolution_changes(initial_size):
|
|
def main():
|
|
def main():
|
|
EPILOG = """This script is not intended for use by end-users. To configure
|
|
EPILOG = """This script is not intended for use by end-users. To configure
|
|
Chrome Remote Desktop, please install the app from the Chrome
|
|
Chrome Remote Desktop, please install the app from the Chrome
|
|
@@ -24364,7 +24364,7 @@ diff --git a/remoting/host/linux/linux_me2me_host.py b/remoting/host/linux/linux
|
|
parser = argparse.ArgumentParser(
|
|
parser = argparse.ArgumentParser(
|
|
usage="Usage: %(prog)s [options] [ -- [ X server options ] ]",
|
|
usage="Usage: %(prog)s [options] [ -- [ X server options ] ]",
|
|
epilog=EPILOG)
|
|
epilog=EPILOG)
|
|
-@@ -1682,7 +1682,7 @@ Web Store: https://chrome.google.com/remotedesktop"""
|
|
|
|
|
|
+@@ -1687,7 +1687,7 @@ Web Store: https://chrome.google.com/remotedesktop"""
|
|
"WARNING: This system uses GDM. Some GDM versions have a bug that "
|
|
"WARNING: This system uses GDM. Some GDM versions have a bug that "
|
|
"prevents local login while Chrome Remote Desktop is running. If you "
|
|
"prevents local login while Chrome Remote Desktop is running. If you "
|
|
"run into this issue, you can stop Chrome Remote Desktop by visiting "
|
|
"run into this issue, you can stop Chrome Remote Desktop by visiting "
|