improved the log

This commit is contained in:
Carmelo Messina 2022-04-14 14:36:15 +02:00
parent 27d9539f17
commit 4ee3723f37
No known key found for this signature in database
GPG key ID: 968894BE688289FD

View file

@ -3,16 +3,16 @@ Date: Thu, 24 Mar 2022 10:08:00 +0000
Subject: Disable TLS Resumption
---
chrome/browser/about_flags.cc | 6 +++++
chrome/browser/flag_descriptions.cc | 8 ++++++
chrome/browser/flag_descriptions.h | 6 +++++
net/base/features.cc | 6 +++++
net/base/features.h | 6 +++++
chrome/browser/about_flags.cc | 6 +++
chrome/browser/flag_descriptions.cc | 8 ++++
chrome/browser/flag_descriptions.h | 6 +++
net/base/features.cc | 6 +++
net/base/features.h | 6 +++
net/http/http_network_session.cc | 1 +
net/quic/quic_stream_factory.cc | 35 +++++++++++++++++++++++-
net/socket/ssl_client_socket_impl.cc | 40 ++++++++++++++++++++++++++++
net/socket/ssl_client_socket_impl.h | 2 ++
9 files changed, 109 insertions(+), 1 deletion(-)
net/quic/quic_stream_factory.cc | 35 ++++++++++++++++-
net/socket/ssl_client_socket_impl.cc | 59 ++++++++++++++++++++++++++++
net/socket/ssl_client_socket_impl.h | 2 +
9 files changed, 128 insertions(+), 1 deletion(-)
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
--- a/chrome/browser/about_flags.cc
@ -212,24 +212,43 @@ diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket
}
transport_adapter_ = std::make_unique<SocketBIOAdapter>(
@@ -1089,6 +1117,16 @@ int SSLClientSocketImpl::DoHandshakeComplete(int result) {
@@ -1089,6 +1117,35 @@ int SSLClientSocketImpl::DoHandshakeComplete(int result) {
: SSLHandshakeDetails::kTLS13Full;
}
}
+ if (base::FeatureList::IsEnabled(net::features::kLogTLSResumption)) {
+ if (details == SSLHandshakeDetails::kTLS13Early)
+ Log_ssl_session_data("SSL session reused: kTLS13Early mode", NULL);
+ else if (details == SSLHandshakeDetails::kTLS13ResumeWithHelloRetryRequest)
+ Log_ssl_session_data("SSL session reused: kTLS13ResumeWithHelloRetryRequest mode", NULL);
+ else if (details == SSLHandshakeDetails::kTLS13Resume)
+ Log_ssl_session_data("SSL session reused: kTLS13Resume mode", NULL);
+ else if (details == SSLHandshakeDetails::kTLS12Resume)
+ Log_ssl_session_data("SSL session reused: kTLS12Resume mode", NULL);
+ switch(details)
+ {
+ case SSLHandshakeDetails::kTLS13Early:
+ Log_ssl_session_data("SSL session reused: kTLS13Early mode", NULL);
+ break;
+ case SSLHandshakeDetails::kTLS13ResumeWithHelloRetryRequest:
+ Log_ssl_session_data("SSL session reused: kTLS13ResumeWithHelloRetryRequest mode", NULL);
+ break;
+ case SSLHandshakeDetails::kTLS13Resume:
+ Log_ssl_session_data("SSL session reused: kTLS13Resume mode", NULL);
+ break;
+ case SSLHandshakeDetails::kTLS12Resume:
+ Log_ssl_session_data("SSL session reused: kTLS12Resume mode", NULL);
+ break;
+ case SSLHandshakeDetails::kTLS12Full:
+ Log_ssl_session_data("SSL session reused: kTLS12Full mode", NULL);
+ break;
+ case SSLHandshakeDetails::kTLS12FalseStart:
+ Log_ssl_session_data("SSL session reused: kTLS12FalseStart mode", NULL);
+ break;
+ case SSLHandshakeDetails::kTLS13Full:
+ Log_ssl_session_data("SSL session reused: kTLS13Full mode", NULL);
+ break;
+ case SSLHandshakeDetails::kTLS13FullWithHelloRetryRequest:
+ Log_ssl_session_data("SSL session reused: kTLS13FullWithHelloRetryRequest mode", NULL);
+ break;
+ }
+ }
UMA_HISTOGRAM_ENUMERATION("Net.SSLHandshakeDetails", details);
// Measure TLS connections that implement the renegotiation_info extension.
@@ -1762,6 +1800,8 @@ bool SSLClientSocketImpl::IsRenegotiationAllowed() const {
@@ -1762,6 +1819,8 @@ bool SSLClientSocketImpl::IsRenegotiationAllowed() const {
}
bool SSLClientSocketImpl::IsCachingEnabled() const {