|
@@ -23,7 +23,7 @@ ld.lld: error: undefined symbol: notifier::NotifierOptions::NotifierOptions()
|
|
|
chrome/android/chrome_java_sources.gni | 38 -----
|
|
|
.../PriceTrackingUtilities.java | 5 +-
|
|
|
.../browser/feed/FeedSurfaceCoordinator.java | 5 +-
|
|
|
- .../browser/feed/FeedSurfaceMediator.java | 88 +---------
|
|
|
+ .../browser/feed/FeedSurfaceMediator.java | 99 +----------
|
|
|
chrome/android/java/AndroidManifest.xml | 8 -
|
|
|
.../android/java/res/xml/main_preferences.xml | 27 +--
|
|
|
.../java/res/xml/privacy_preferences.xml | 4 -
|
|
@@ -37,7 +37,7 @@ ld.lld: error: undefined symbol: notifier::NotifierOptions::NotifierOptions()
|
|
|
.../contextualsearch/ContextualSearchUma.java | 5 -
|
|
|
.../browser/customtabs/CustomTabActivity.java | 3 -
|
|
|
.../DataReductionPreferenceFragment.java | 24 +--
|
|
|
- .../browser/firstrun/FirstRunActivity.java | 30 ----
|
|
|
+ .../browser/firstrun/FirstRunActivity.java | 40 -----
|
|
|
.../firstrun/FirstRunFlowSequencer.java | 31 +---
|
|
|
.../firstrun/LightweightFirstRunActivity.java | 6 +-
|
|
|
.../firstrun/ToSAndUMAFirstRunFragment.java | 11 --
|
|
@@ -56,7 +56,6 @@ ld.lld: error: undefined symbol: notifier::NotifierOptions::NotifierOptions()
|
|
|
.../browser/share/ShareDelegateImpl.java | 3 +-
|
|
|
.../share/ShareRegistrationCoordinator.java | 3 +-
|
|
|
.../SharedClipboardShareActivity.java | 3 -
|
|
|
- .../browser/signin/SigninCheckerProvider.java | 38 -----
|
|
|
.../tabbed_mode/TabbedRootUiCoordinator.java | 22 +--
|
|
|
.../tasks/ReturnToChromeExperimentsUtil.java | 9 +-
|
|
|
chrome/browser/BUILD.gn | 10 --
|
|
@@ -66,19 +65,18 @@ ld.lld: error: undefined symbol: notifier::NotifierOptions::NotifierOptions()
|
|
|
.../ui/ConfirmSyncDataStateMachine.java | 16 +-
|
|
|
.../signin/ui/SignOutDialogFragment.java | 13 --
|
|
|
.../signin/ui/SigninPromoController.java | 15 +-
|
|
|
- .../AccountPickerDelegateImpl.java | 17 --
|
|
|
+ .../AccountPickerDelegateImpl.java | 18 --
|
|
|
chrome/browser/sync/sync_service_factory.cc | 12 +-
|
|
|
.../strings/android_chrome_strings.grd | 12 --
|
|
|
.../signin/SystemAccountManagerDelegate.java | 35 +---
|
|
|
.../net/HttpNegotiateAuthenticator.java | 88 +---------
|
|
|
.../chromoting/base/OAuthTokenFetcher.java | 2 -
|
|
|
- 53 files changed, 48 insertions(+), 1195 deletions(-)
|
|
|
- delete mode 100644 chrome/android/java/src/org/chromium/chrome/browser/signin/SigninCheckerProvider.java
|
|
|
+ 52 files changed, 48 insertions(+), 1179 deletions(-)
|
|
|
|
|
|
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
|
|
--- a/chrome/android/BUILD.gn
|
|
|
+++ b/chrome/android/BUILD.gn
|
|
|
-@@ -3700,7 +3700,6 @@ generate_jni("chrome_jni_headers") {
|
|
|
+@@ -3794,7 +3794,6 @@ generate_jni("chrome_jni_headers") {
|
|
|
"java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java",
|
|
|
"java/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBar.java",
|
|
|
"java/src/org/chromium/chrome/browser/infobar/SurveyInfoBar.java",
|
|
@@ -89,7 +87,7 @@ diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
|
|
diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
|
|
|
--- a/chrome/android/chrome_java_sources.gni
|
|
|
+++ b/chrome/android/chrome_java_sources.gni
|
|
|
-@@ -604,15 +604,12 @@ chrome_java_sources = [
|
|
|
+@@ -606,15 +606,12 @@ chrome_java_sources = [
|
|
|
"java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java",
|
|
|
"java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java",
|
|
|
"java/src/org/chromium/chrome/browser/firstrun/FirstRunPagerAdapter.java",
|
|
@@ -105,7 +103,7 @@ diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java
|
|
|
"java/src/org/chromium/chrome/browser/firstrun/TabbedModeFirstRunActivity.java",
|
|
|
"java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java",
|
|
|
"java/src/org/chromium/chrome/browser/firstrun/TosAndUmaFirstRunFragmentWithEnterpriseSupport.java",
|
|
|
-@@ -709,7 +706,6 @@ chrome_java_sources = [
|
|
|
+@@ -708,7 +705,6 @@ chrome_java_sources = [
|
|
|
"java/src/org/chromium/chrome/browser/infobar/SubPanelListener.java",
|
|
|
"java/src/org/chromium/chrome/browser/infobar/SurveyInfoBar.java",
|
|
|
"java/src/org/chromium/chrome/browser/infobar/SurveyInfoBarDelegate.java",
|
|
@@ -113,7 +111,7 @@ diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java
|
|
|
"java/src/org/chromium/chrome/browser/infobar/TextViewEllipsizerSafe.java",
|
|
|
"java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java",
|
|
|
"java/src/org/chromium/chrome/browser/infobar/UpdatePasswordInfoBar.java",
|
|
|
-@@ -826,7 +822,6 @@ chrome_java_sources = [
|
|
|
+@@ -825,7 +821,6 @@ chrome_java_sources = [
|
|
|
"java/src/org/chromium/chrome/browser/ntp/ScrollableContainerDelegate.java",
|
|
|
"java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java",
|
|
|
"java/src/org/chromium/chrome/browser/ntp/TitleUtil.java",
|
|
@@ -121,7 +119,7 @@ diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java
|
|
|
"java/src/org/chromium/chrome/browser/ntp/cards/promo/enhanced_protection/EnhancedProtectionPromoController.java",
|
|
|
"java/src/org/chromium/chrome/browser/ntp/cards/promo/enhanced_protection/EnhancedProtectionPromoUtils.java",
|
|
|
"java/src/org/chromium/chrome/browser/ntp/search/SearchBoxChipDelegate.java",
|
|
|
-@@ -913,8 +908,6 @@ chrome_java_sources = [
|
|
|
+@@ -912,8 +907,6 @@ chrome_java_sources = [
|
|
|
"java/src/org/chromium/chrome/browser/partnerbookmarks/PartnerBookmarksShim.java",
|
|
|
"java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java",
|
|
|
"java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java",
|
|
@@ -130,7 +128,7 @@ diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java
|
|
|
"java/src/org/chromium/chrome/browser/password_manager/Credential.java",
|
|
|
"java/src/org/chromium/chrome/browser/password_manager/CredentialLeakDialogBridge.java",
|
|
|
"java/src/org/chromium/chrome/browser/password_manager/GooglePasswordManagerUIProvider.java",
|
|
|
-@@ -1061,16 +1054,6 @@ chrome_java_sources = [
|
|
|
+@@ -1060,16 +1053,6 @@ chrome_java_sources = [
|
|
|
"java/src/org/chromium/chrome/browser/sharing/shared_clipboard/SharedClipboardMetrics.java",
|
|
|
"java/src/org/chromium/chrome/browser/sharing/shared_clipboard/SharedClipboardShareActivity.java",
|
|
|
"java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java",
|
|
@@ -147,7 +145,7 @@ diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java
|
|
|
"java/src/org/chromium/chrome/browser/site_settings/ChromeSiteSettingsDelegate.java",
|
|
|
"java/src/org/chromium/chrome/browser/site_settings/CookieControlsServiceBridge.java",
|
|
|
"java/src/org/chromium/chrome/browser/site_settings/ManageSpaceActivity.java",
|
|
|
-@@ -1107,27 +1090,6 @@ chrome_java_sources = [
|
|
|
+@@ -1106,27 +1089,6 @@ chrome_java_sources = [
|
|
|
"java/src/org/chromium/chrome/browser/survey/ChromeSurveyController.java",
|
|
|
"java/src/org/chromium/chrome/browser/survey/SurveyController.java",
|
|
|
"java/src/org/chromium/chrome/browser/survey/SurveyHttpClientBridge.java",
|
|
@@ -200,7 +198,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
|
|
diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java b/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java
|
|
|
--- a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java
|
|
|
+++ b/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java
|
|
|
-@@ -898,10 +898,7 @@ public class FeedSurfaceCoordinator
|
|
|
+@@ -938,10 +938,7 @@ public class FeedSurfaceCoordinator implements FeedSurfaceProvider, FeedBubbleDe
|
|
|
|
|
|
@Override
|
|
|
public boolean isSignedIn() {
|
|
@@ -234,7 +232,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
import org.chromium.chrome.browser.suggestions.SuggestionsMetrics;
|
|
|
import org.chromium.chrome.browser.xsurface.FeedLaunchReliabilityLogger;
|
|
|
import org.chromium.chrome.features.start_surface.StartSurfaceConfiguration;
|
|
|
-@@ -173,7 +168,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -179,7 +174,6 @@ public class FeedSurfaceMediator
|
|
|
/**
|
|
|
* The {@link SignInPromo} for the Feed.
|
|
|
* TODO(huayinz): Update content and visibility through a ModelChangeProcessor.
|
|
@@ -242,7 +240,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
private class FeedSignInPromo extends SignInPromo {
|
|
|
FeedSignInPromo(SigninManager signinManager) {
|
|
|
super(signinManager);
|
|
|
-@@ -194,7 +188,7 @@ public class FeedSurfaceMediator
|
|
|
+@@ -200,7 +194,7 @@ public class FeedSurfaceMediator
|
|
|
maybeUpdateSignInPromo();
|
|
|
}
|
|
|
|
|
@@ -251,16 +249,16 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
private void maybeUpdateSignInPromo() {
|
|
|
// Only call #setupPromoViewFromCache() if SignInPromo is visible to avoid potentially
|
|
|
// blocking the UI thread for several seconds if the accounts cache is not populated
|
|
|
-@@ -206,7 +200,7 @@ public class FeedSurfaceMediator
|
|
|
- null);
|
|
|
- }
|
|
|
+@@ -222,7 +216,7 @@ public class FeedSurfaceMediator
|
|
|
+ super.onDismissPromo();
|
|
|
+ mCoordinator.updateHeaderViews(false, null);
|
|
|
}
|
|
|
- }
|
|
|
+ } */
|
|
|
|
|
|
@VisibleForTesting
|
|
|
static void setPrefForTest(PrefChangeRegistrar prefChangeRegistrar, PrefService prefService) {
|
|
|
-@@ -221,7 +215,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -237,7 +231,6 @@ public class FeedSurfaceMediator
|
|
|
private final Context mContext;
|
|
|
private final @Nullable SnapScrollHelper mSnapScrollHelper;
|
|
|
private final PrefChangeRegistrar mPrefChangeRegistrar;
|
|
@@ -268,7 +266,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
private final PropertyModel mSectionHeaderModel;
|
|
|
|
|
|
private final NativePageNavigationDelegate mPageNavigationDelegate;
|
|
|
-@@ -230,7 +223,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -246,7 +239,6 @@ public class FeedSurfaceMediator
|
|
|
private final ObserverList<ScrollListener> mScrollListeners = new ObserverList<>();
|
|
|
private ContentChangedListener mStreamContentChangedListener;
|
|
|
private MemoryPressureCallback mMemoryPressureCallback;
|
|
@@ -276,7 +274,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
private RecyclerViewAnimationFinishDetector mRecyclerViewAnimationFinishDetector =
|
|
|
new RecyclerViewAnimationFinishDetector();
|
|
|
private @Nullable View mEnhancedProtectionPromo;
|
|
|
-@@ -279,8 +271,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -295,8 +287,6 @@ public class FeedSurfaceMediator
|
|
|
mCoordinator = coordinator;
|
|
|
mContext = context;
|
|
|
mSnapScrollHelper = snapScrollHelper;
|
|
@@ -285,15 +283,15 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
mPageNavigationDelegate = pageNavigationDelegate;
|
|
|
|
|
|
if (sTestPrefChangeRegistar != null) {
|
|
|
-@@ -435,7 +425,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -454,7 +444,6 @@ public class FeedSurfaceMediator
|
|
|
mFeedMenuModel = buildMenuItems();
|
|
|
|
|
|
- mCoordinator.initializeIph();
|
|
|
+ mCoordinator.initializeBubbleTriggering();
|
|
|
- mSigninManager.getIdentityManager().addObserver(this);
|
|
|
|
|
|
mSectionHeaderModel.set(
|
|
|
SectionHeaderListProperties.MENU_MODEL_LIST_KEY, mFeedMenuModel);
|
|
|
-@@ -487,8 +476,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -506,8 +495,6 @@ public class FeedSurfaceMediator
|
|
|
};
|
|
|
mCoordinator.getRecyclerView().addOnScrollListener(mStreamScrollListener);
|
|
|
|
|
@@ -302,7 +300,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
mMemoryPressureCallback =
|
|
|
pressure -> mCoordinator.getRecyclerView().getRecycledViewPool().clear();
|
|
|
MemoryPressureListener.addCallback(mMemoryPressureCallback);
|
|
|
-@@ -644,46 +631,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -663,47 +650,6 @@ public class FeedSurfaceMediator
|
|
|
}
|
|
|
}
|
|
|
|
|
@@ -321,6 +319,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
- * @return Whether the SignPromo should be visible.
|
|
|
- */
|
|
|
- private boolean createSignInPromoIfNeeded() {
|
|
|
+- SigninPromoController.resetNTPSyncPromoLimitsIfHiddenForTooLong();
|
|
|
- if (!SignInPromo.shouldCreatePromo()
|
|
|
- || !SigninPromoController.canShowSyncPromo(
|
|
|
- SigninAccessPoint.NTP_CONTENT_SUGGESTIONS)) {
|
|
@@ -349,7 +348,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
private void updatePromoCardPadding(View promoCard) {
|
|
|
MarginLayoutParams layoutParams = promoCard.getLayoutParams() == null
|
|
|
? new MarginLayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT)
|
|
|
-@@ -706,11 +653,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -726,11 +672,6 @@ public class FeedSurfaceMediator
|
|
|
MemoryPressureListener.removeCallback(mMemoryPressureCallback);
|
|
|
mMemoryPressureCallback = null;
|
|
|
|
|
@@ -361,7 +360,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
unbindStream();
|
|
|
for (Stream s : mTabToStreamMap.values()) {
|
|
|
s.removeOnContentChangedListener(mStreamContentChangedListener);
|
|
|
-@@ -721,7 +663,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -741,7 +682,6 @@ public class FeedSurfaceMediator
|
|
|
|
|
|
mPrefChangeRegistrar.removeObserver(Pref.ARTICLES_LIST_VISIBLE);
|
|
|
TemplateUrlServiceFactory.get().removeObserver(this);
|
|
@@ -369,7 +368,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
|
|
|
PropertyListModel<PropertyModel, PropertyKey> headerList =
|
|
|
mSectionHeaderModel.get(SectionHeaderListProperties.SECTION_HEADERS_KEY);
|
|
|
-@@ -789,9 +730,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -820,9 +760,6 @@ public class FeedSurfaceMediator
|
|
|
// Update toggleswitch item, which is last item in list.
|
|
|
mSectionHeaderModel.set(SectionHeaderListProperties.MENU_MODEL_LIST_KEY, buildMenuItems());
|
|
|
|
|
@@ -379,7 +378,7 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
if (mEnhancedProtectionPromo != null) {
|
|
|
updatePromoCardPadding(mEnhancedProtectionPromo);
|
|
|
}
|
|
|
-@@ -807,7 +745,7 @@ public class FeedSurfaceMediator
|
|
|
+@@ -838,7 +775,7 @@ public class FeedSurfaceMediator
|
|
|
}
|
|
|
|
|
|
private boolean isSignedIn() {
|
|
@@ -388,12 +387,13 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
}
|
|
|
|
|
|
/**
|
|
|
-@@ -856,21 +794,6 @@ public class FeedSurfaceMediator
|
|
|
+@@ -886,31 +823,6 @@ public class FeedSurfaceMediator
|
|
|
+
|
|
|
private ModelList buildMenuItems() {
|
|
|
ModelList itemList = new ModelList();
|
|
|
- int iconId = 0;
|
|
|
+- int iconId = 0;
|
|
|
- if (isSignedIn()) {
|
|
|
-- if (FeedFeatures.isWebFeedUIEnabled()) {
|
|
|
+- if (ChromeFeatureList.isEnabled(ChromeFeatureList.WEB_FEED)) {
|
|
|
- itemList.add(buildMenuListItem(
|
|
|
- R.string.ntp_manage_feed, R.id.ntp_feed_header_menu_item_manage, iconId));
|
|
|
- } else {
|
|
@@ -407,10 +407,19 @@ diff --git a/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/
|
|
|
- R.id.ntp_feed_header_menu_item_reactions, iconId));
|
|
|
- }
|
|
|
- }
|
|
|
- if (FeedServiceBridge.isAutoplayEnabled()) {
|
|
|
- itemList.add(buildMenuListItem(
|
|
|
- R.string.ntp_manage_autoplay, R.id.ntp_feed_header_menu_item_autoplay, iconId));
|
|
|
-@@ -1081,11 +1004,6 @@ public class FeedSurfaceMediator
|
|
|
+- if (FeedServiceBridge.isAutoplayEnabled()) {
|
|
|
+- itemList.add(buildMenuListItem(
|
|
|
+- R.string.ntp_manage_autoplay, R.id.ntp_feed_header_menu_item_autoplay, iconId));
|
|
|
+- }
|
|
|
+- itemList.add(buildMenuListItem(
|
|
|
+- R.string.learn_more, R.id.ntp_feed_header_menu_item_learn, iconId));
|
|
|
+- itemList.add(getMenuToggleSwitch(
|
|
|
+- mSectionHeaderModel.get(SectionHeaderListProperties.IS_SECTION_ENABLED_KEY),
|
|
|
+- iconId));
|
|
|
+ return itemList;
|
|
|
+ }
|
|
|
+
|
|
|
+@@ -1112,11 +1024,6 @@ public class FeedSurfaceMediator
|
|
|
updateSectionHeader();
|
|
|
}
|
|
|
|
|
@@ -509,7 +518,7 @@ diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/j
|
|
|
diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
|
|
--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
|
|
+++ b/chrome/android/java/res/xml/privacy_preferences.xml
|
|
|
-@@ -36,8 +36,4 @@
|
|
|
+@@ -40,8 +40,4 @@
|
|
|
android:key="privacy_sandbox"
|
|
|
android:title="@string/prefs_privacy_sandbox"
|
|
|
android:fragment="org.chromium.chrome.browser.privacy_sandbox.PrivacySandboxSettingsFragment"/>
|
|
@@ -529,7 +538,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java b
|
|
|
import org.chromium.chrome.browser.tab.Tab;
|
|
|
import org.chromium.chrome.browser.usage_stats.DigitalWellbeingClient;
|
|
|
import org.chromium.chrome.browser.webapps.GooglePlayWebApkInstallDelegate;
|
|
|
-@@ -285,13 +284,6 @@ public abstract class AppHooks {
|
|
|
+@@ -288,13 +287,6 @@ public abstract class AppHooks {
|
|
|
return ConnectionResult.SERVICE_VERSION_UPDATE_REQUIRED;
|
|
|
}
|
|
|
|
|
@@ -554,7 +563,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
|
|
import org.chromium.chrome.browser.flags.ActivityType;
|
|
|
import org.chromium.chrome.browser.flags.CachedFeatureFlags;
|
|
|
import org.chromium.chrome.browser.flags.ChromeFeatureList;
|
|
|
-@@ -102,7 +101,6 @@ import org.chromium.chrome.browser.incognito.IncognitoTabLauncher;
|
|
|
+@@ -103,7 +102,6 @@ import org.chromium.chrome.browser.incognito.IncognitoTabLauncher;
|
|
|
import org.chromium.chrome.browser.incognito.IncognitoTabSnapshotController;
|
|
|
import org.chromium.chrome.browser.incognito.IncognitoUtils;
|
|
|
import org.chromium.chrome.browser.infobar.DataReductionPromoInfoBar;
|
|
@@ -562,7 +571,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
|
|
import org.chromium.chrome.browser.layouts.LayoutStateProvider;
|
|
|
import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher;
|
|
|
import org.chromium.chrome.browser.locale.LocaleManager;
|
|
|
-@@ -641,9 +639,6 @@ public class ChromeTabbedActivity extends ChromeActivity<ChromeActivityComponent
|
|
|
+@@ -643,9 +641,6 @@ public class ChromeTabbedActivity extends ChromeActivity<ChromeActivityComponent
|
|
|
}
|
|
|
|
|
|
private void refreshSignIn() {
|
|
@@ -572,7 +581,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
|
|
}
|
|
|
|
|
|
private void setupCompositorContentPreNativeForPhone() {
|
|
|
-@@ -1796,7 +1791,6 @@ public class ChromeTabbedActivity extends ChromeActivity<ChromeActivityComponent
|
|
|
+@@ -1806,7 +1801,6 @@ public class ChromeTabbedActivity extends ChromeActivity<ChromeActivityComponent
|
|
|
DataReductionPromoInfoBar.maybeLaunchPromoInfoBar(ChromeTabbedActivity.this,
|
|
|
tab.getWebContents(), navigation.getUrl(), tab.isShowingErrorPage(),
|
|
|
navigation.isFragmentNavigation(), navigation.httpStatusCode());
|
|
@@ -591,7 +600,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
|
|
import org.chromium.chrome.browser.flags.ActivityType;
|
|
|
import org.chromium.chrome.browser.flags.CachedFeatureFlags;
|
|
|
import org.chromium.chrome.browser.flags.ChromeFeatureList;
|
|
|
-@@ -154,7 +153,6 @@ import org.chromium.chrome.browser.share.ShareDelegate;
|
|
|
+@@ -155,7 +154,6 @@ import org.chromium.chrome.browser.share.ShareDelegate;
|
|
|
import org.chromium.chrome.browser.share.ShareDelegateImpl;
|
|
|
import org.chromium.chrome.browser.share.ShareDelegateSupplier;
|
|
|
import org.chromium.chrome.browser.share.ShareRegistrationCoordinator;
|
|
@@ -599,7 +608,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
|
|
import org.chromium.chrome.browser.tab.AccessibilityVisibilityHandler;
|
|
|
import org.chromium.chrome.browser.tab.RequestDesktopUtils;
|
|
|
import org.chromium.chrome.browser.tab.Tab;
|
|
|
-@@ -211,8 +209,6 @@ import org.chromium.components.page_info.PageInfoController.OpenedFromSource;
|
|
|
+@@ -214,8 +212,6 @@ import org.chromium.components.page_info.PageInfoController.OpenedFromSource;
|
|
|
import org.chromium.components.policy.CombinedPolicyProvider;
|
|
|
import org.chromium.components.policy.CombinedPolicyProvider.PolicyChangeListener;
|
|
|
import org.chromium.components.profile_metrics.BrowserProfileType;
|
|
@@ -608,7 +617,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
|
|
import org.chromium.components.user_prefs.UserPrefs;
|
|
|
import org.chromium.components.webapk.lib.client.WebApkValidator;
|
|
|
import org.chromium.components.webapps.AddToHomescreenCoordinator;
|
|
|
-@@ -304,9 +300,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+@@ -307,9 +303,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
private boolean mRemoveWindowBackgroundDone;
|
|
|
protected AccessibilityVisibilityHandler mAccessibilityVisibilityHandler;
|
|
|
|
|
@@ -618,7 +627,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
|
|
// The PictureInPictureController is initialized lazily https://crbug.com/729738.
|
|
|
private PictureInPictureController mPictureInPictureController;
|
|
|
|
|
|
-@@ -1062,60 +1055,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+@@ -1070,60 +1063,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
return StatusBarColorController.UNDEFINED_STATUS_BAR_COLOR;
|
|
|
}
|
|
|
|
|
@@ -679,7 +688,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
|
|
@Override
|
|
|
public void onResumeWithNative() {
|
|
|
super.onResumeWithNative();
|
|
|
-@@ -1214,14 +1153,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+@@ -1226,14 +1165,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
if (GSAState.getInstance(this).isGsaAvailable() && !SysUtils.isLowEndDevice()) {
|
|
|
if (mGSAAccountChangeListener != null) mGSAAccountChangeListener.disconnect();
|
|
|
}
|
|
@@ -694,7 +703,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
|
|
|
|
|
super.onStopWithNative();
|
|
|
}
|
|
|
-@@ -1326,11 +1257,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+@@ -1338,11 +1269,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
FontSizePrefs.getInstance().recordUserFontPrefOnStartup();
|
|
|
});
|
|
|
|
|
@@ -706,7 +715,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
|
|
// GSA connection is not needed on low-end devices because Icing is disabled.
|
|
|
if (!SysUtils.isLowEndDevice()) {
|
|
|
if (isActivityFinishingOrDestroyed()) return;
|
|
|
-@@ -1345,7 +1271,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+@@ -1357,7 +1283,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
GSAAccountChangeListener.create(AppHooks.get().createGsaHelper());
|
|
|
}
|
|
|
mGSAAccountChangeListener.connect();
|
|
@@ -1157,7 +1166,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearc
|
|
|
|
|
|
import java.lang.annotation.Retention;
|
|
|
import java.lang.annotation.RetentionPolicy;
|
|
|
-@@ -850,10 +849,6 @@ public class ContextualSearchUma {
|
|
|
+@@ -882,10 +881,6 @@ public class ContextualSearchUma {
|
|
|
public static void logTapResultsSeen(boolean wasPanelSeen) {
|
|
|
RecordHistogram.recordBooleanHistogram(
|
|
|
"Search.ContextualSearch.Tap.ResultsSeen", wasPanelSeen);
|
|
@@ -1232,7 +1241,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/datareduction/s
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
|
|
|
-@@ -27,12 +27,9 @@ import org.chromium.base.metrics.RecordHistogram;
|
|
|
+@@ -27,14 +27,10 @@ import org.chromium.base.metrics.RecordHistogram;
|
|
|
import org.chromium.base.supplier.Supplier;
|
|
|
import org.chromium.chrome.R;
|
|
|
import org.chromium.chrome.browser.customtabs.CustomTabActivity;
|
|
@@ -1243,9 +1252,11 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstR
|
|
|
import org.chromium.chrome.browser.metrics.UmaUtils;
|
|
|
-import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
|
|
|
import org.chromium.chrome.browser.search_engines.TemplateUrlServiceFactory;
|
|
|
- import org.chromium.chrome.browser.searchwidget.SearchWidgetProvider;
|
|
|
+-import org.chromium.chrome.browser.signin.SigninFirstRunFragment;
|
|
|
+ import org.chromium.chrome.browser.signin.services.FREMobileIdentityConsistencyFieldTrial;
|
|
|
import org.chromium.components.browser_ui.modaldialog.AppModalPresenter;
|
|
|
-@@ -103,7 +100,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
+ import org.chromium.ui.base.LocalizationUtils;
|
|
|
+@@ -104,7 +100,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
|
|
|
private static final int FRE_PROGRESS_STARTED = 0;
|
|
|
private static final int FRE_PROGRESS_WELCOME_SHOWN = 1;
|
|
@@ -1253,26 +1264,42 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstR
|
|
|
private static final int FRE_PROGRESS_SIGNIN_SHOWN = 3;
|
|
|
private static final int FRE_PROGRESS_COMPLETED_SIGNED_IN = 4;
|
|
|
private static final int FRE_PROGRESS_COMPLETED_NOT_SIGNED_IN = 5;
|
|
|
-@@ -183,13 +179,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
+@@ -155,7 +150,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
+ private void createPageSequence() {
|
|
|
+ FREMobileIdentityConsistencyFieldTrial.createFirstRunTrial();
|
|
|
+ if (FREMobileIdentityConsistencyFieldTrial.isEnabled()) {
|
|
|
+- mPages.add(SigninFirstRunFragment::new);
|
|
|
+ } else {
|
|
|
+ mPages.add(shouldCreateEnterpriseCctTosPage()
|
|
|
+ ? new TosAndUmaFirstRunFragmentWithEnterpriseSupport.Page()
|
|
|
+@@ -189,20 +183,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
mFirstRunFlowSequencer.onNativeAndPoliciesInitialized(mFreProperties);
|
|
|
|
|
|
boolean notifyAdapter = false;
|
|
|
+- // An optional sign-in page.
|
|
|
+- if (FREMobileIdentityConsistencyFieldTrial.isEnabled()
|
|
|
+- && mFreProperties.getBoolean(SHOW_SIGNIN_PAGE)) {
|
|
|
+- mPages.add(SyncConsentFirstRunFragment::new);
|
|
|
+- mFreProgressStates.add(FRE_PROGRESS_SIGNIN_SHOWN);
|
|
|
+- notifyAdapter = true;
|
|
|
+- }
|
|
|
+-
|
|
|
- // An optional Data Saver page.
|
|
|
- if (mFreProperties.getBoolean(SHOW_DATA_REDUCTION_PAGE)) {
|
|
|
- mPages.add(new DataReductionProxyFirstRunFragment.Page());
|
|
|
- mFreProgressStates.add(FRE_PROGRESS_DATA_SAVER_SHOWN);
|
|
|
- notifyAdapter = true;
|
|
|
- }
|
|
|
--
|
|
|
+
|
|
|
// An optional page to select a default search engine.
|
|
|
if (mFreProperties.getBoolean(SHOW_SEARCH_ENGINE_PAGE)) {
|
|
|
- mPages.add(new DefaultSearchEngineFirstRunFragment.Page());
|
|
|
-@@ -197,13 +186,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
+@@ -211,14 +191,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
notifyAdapter = true;
|
|
|
}
|
|
|
|
|
|
- // An optional sign-in page.
|
|
|
-- if (mFreProperties.getBoolean(SHOW_SIGNIN_PAGE)) {
|
|
|
+- if (!FREMobileIdentityConsistencyFieldTrial.isEnabled()
|
|
|
+- && mFreProperties.getBoolean(SHOW_SIGNIN_PAGE)) {
|
|
|
- mPages.add(SyncConsentFirstRunFragment::new);
|
|
|
- mFreProgressStates.add(FRE_PROGRESS_SIGNIN_SHOWN);
|
|
|
- notifyAdapter = true;
|
|
@@ -1281,7 +1308,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstR
|
|
|
if (notifyAdapter && mPagerAdapter != null) {
|
|
|
mPagerAdapter.notifyDataSetChanged();
|
|
|
}
|
|
|
-@@ -474,18 +456,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
+@@ -489,18 +461,6 @@ public class FirstRunActivity extends FirstRunActivityBase implements FirstRunPa
|
|
|
FirstRunFlowSequencer.markFlowAsCompleted(
|
|
|
mResultSignInAccountName, mResultShowSignInSettings);
|
|
|
|
|
@@ -1297,9 +1324,9 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstR
|
|
|
- }
|
|
|
- }
|
|
|
-
|
|
|
- // Update the search engine name cached by the widget.
|
|
|
- SearchWidgetProvider.updateCachedEngineName();
|
|
|
if (sObserver != null) sObserver.onUpdateCachedEngineName(this);
|
|
|
+
|
|
|
+ launchPendingIntentAndFinish();
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
|
|
@@ -1491,9 +1518,9 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessIni
|
|
|
import org.chromium.chrome.browser.sharing.shared_clipboard.SharedClipboardShareActivity;
|
|
|
-import org.chromium.chrome.browser.signin.SigninCheckerProvider;
|
|
|
import org.chromium.chrome.browser.tab.state.ShoppingPersistedTabData;
|
|
|
+ import org.chromium.chrome.browser.ui.searchactivityutils.SearchActivityPreferencesManager;
|
|
|
import org.chromium.chrome.browser.util.AfterStartupTaskUtils;
|
|
|
- import org.chromium.chrome.browser.webapps.WebApkVersionManager;
|
|
|
-@@ -209,7 +207,6 @@ public class ProcessInitializationHandler {
|
|
|
+@@ -207,7 +205,6 @@ public class ProcessInitializationHandler {
|
|
|
* Performs the post native initialization.
|
|
|
*/
|
|
|
protected void handlePostNativeInitialization() {
|
|
@@ -1501,7 +1528,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessIni
|
|
|
ChromeActivitySessionTracker.getInstance().initializeWithNative();
|
|
|
ProfileManagerUtils.removeSessionCookiesForAllProfiles();
|
|
|
AppBannerManager.setAppDetailsDelegate(AppHooks.get().createAppDetailsDelegate());
|
|
|
-@@ -364,7 +361,6 @@ public class ProcessInitializationHandler {
|
|
|
+@@ -356,7 +353,6 @@ public class ProcessInitializationHandler {
|
|
|
deferredStartupHandler.addDeferredTask(new Runnable() {
|
|
|
@Override
|
|
|
public void run() {
|
|
@@ -1830,7 +1857,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manage
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
|
|
-@@ -27,8 +27,6 @@ import org.chromium.chrome.browser.profiles.Profile;
|
|
|
+@@ -26,8 +26,6 @@ import org.chromium.chrome.browser.profiles.Profile;
|
|
|
import org.chromium.chrome.browser.settings.ChromeManagedPreferenceDelegate;
|
|
|
import org.chromium.chrome.browser.settings.SettingsLauncherImpl;
|
|
|
import org.chromium.chrome.browser.signin.services.IdentityServicesProvider;
|
|
@@ -1839,15 +1866,15 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
|
|
import org.chromium.components.browser_ui.settings.ChromeSwitchPreference;
|
|
|
import org.chromium.components.browser_ui.settings.ManagedPreferenceDelegate;
|
|
|
import org.chromium.components.browser_ui.settings.SettingsLauncher;
|
|
|
-@@ -49,7 +47,6 @@ public class PrivacySettings
|
|
|
+@@ -48,7 +46,6 @@ public class PrivacySettings
|
|
|
private static final String PREF_HTTPS_FIRST_MODE = "https_first_mode";
|
|
|
private static final String PREF_SECURE_DNS = "secure_dns";
|
|
|
private static final String PREF_DO_NOT_TRACK = "do_not_track";
|
|
|
- private static final String PREF_SYNC_AND_SERVICES_LINK = "sync_and_services_link";
|
|
|
private static final String PREF_CLEAR_BROWSING_DATA = "clear_browsing_data";
|
|
|
private static final String PREF_PRIVACY_SANDBOX = "privacy_sandbox";
|
|
|
-
|
|
|
-@@ -106,36 +103,9 @@ public class PrivacySettings
|
|
|
+ private static final String PREF_PRIVACY_REVIEW = "privacy_review";
|
|
|
+@@ -105,36 +102,9 @@ public class PrivacySettings
|
|
|
Preference secureDnsPref = findPreference(PREF_SECURE_DNS);
|
|
|
secureDnsPref.setVisible(SecureDnsSettings.isUiEnabled());
|
|
|
|
|
@@ -2100,7 +2127,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/MainSe
|
|
|
- mSyncPromoPreference.getState() == State.PERSONALIZED_SIGNIN_PROMO;
|
|
|
- findPreference(PREF_ACCOUNT_AND_GOOGLE_SERVICES_SECTION)
|
|
|
- .setVisible(!isShowingPersonalizedSigninPromo);
|
|
|
-- mSignInPreference.setVisible(!isShowingPersonalizedSigninPromo);
|
|
|
+- mSignInPreference.setIsShowingPersonalizedSigninPromo(isShowingPersonalizedSigninPromo);
|
|
|
- }
|
|
|
-
|
|
|
// TemplateUrlService.LoadListener implementation.
|
|
@@ -2227,49 +2254,6 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sharing/shared_
|
|
|
|
|
|
onInitialLayoutInflationComplete();
|
|
|
}
|
|
|
-diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninCheckerProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninCheckerProvider.java
|
|
|
-deleted file mode 100644
|
|
|
---- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninCheckerProvider.java
|
|
|
-+++ /dev/null
|
|
|
-@@ -1,38 +0,0 @@
|
|
|
--// Copyright 2020 The Chromium Authors. All rights reserved.
|
|
|
--// Use of this source code is governed by a BSD-style license that can be
|
|
|
--// found in the LICENSE file.
|
|
|
--
|
|
|
--package org.chromium.chrome.browser.signin;
|
|
|
--
|
|
|
--import androidx.annotation.MainThread;
|
|
|
--
|
|
|
--import org.chromium.chrome.browser.profiles.Profile;
|
|
|
--import org.chromium.chrome.browser.signin.services.IdentityServicesProvider;
|
|
|
--import org.chromium.chrome.browser.sync.SyncController;
|
|
|
--import org.chromium.chrome.browser.sync.SyncErrorNotifier;
|
|
|
--
|
|
|
--/**
|
|
|
-- * This class is used to get a singleton instance of {@link SigninChecker}.
|
|
|
-- */
|
|
|
--public final class SigninCheckerProvider {
|
|
|
-- private static SigninChecker sInstance;
|
|
|
--
|
|
|
-- /**
|
|
|
-- * @return A singleton instance of {@link SigninChecker}.
|
|
|
-- */
|
|
|
-- @MainThread
|
|
|
-- public static SigninChecker get() {
|
|
|
-- if (sInstance == null) {
|
|
|
-- // SyncController and SyncErrorNotifier must be explicitly initialized.
|
|
|
-- // TODO(crbug.com/1156620): Move the initializations elsewhere.
|
|
|
-- SyncErrorNotifier.get();
|
|
|
-- SyncController.get();
|
|
|
-- Profile profile = Profile.getLastUsedRegularProfile();
|
|
|
-- sInstance = new SigninChecker(IdentityServicesProvider.get().getSigninManager(profile),
|
|
|
-- IdentityServicesProvider.get().getAccountTrackerService(profile));
|
|
|
-- }
|
|
|
-- return sInstance;
|
|
|
-- }
|
|
|
--
|
|
|
-- private SigninCheckerProvider() {}
|
|
|
--}
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
|
@@ -2290,7 +2274,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
|
|
import org.chromium.chrome.browser.status_indicator.StatusIndicatorCoordinator;
|
|
|
import org.chromium.chrome.browser.subscriptions.CommerceSubscriptionsService;
|
|
|
import org.chromium.chrome.browser.subscriptions.CommerceSubscriptionsServiceFactory;
|
|
|
-@@ -862,23 +859,6 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
|
|
+@@ -863,23 +860,6 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
|
|
}
|
|
|
|
|
|
private boolean maybeShowPromo() {
|
|
@@ -2318,7 +2302,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToChromeExperimentsUtil.java b/chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToChromeExperimentsUtil.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToChromeExperimentsUtil.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToChromeExperimentsUtil.java
|
|
|
-@@ -35,7 +35,6 @@ import org.chromium.chrome.browser.omnibox.UrlFocusChangeListener;
|
|
|
+@@ -36,7 +36,6 @@ import org.chromium.chrome.browser.omnibox.UrlFocusChangeListener;
|
|
|
import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
|
|
|
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
|
|
|
import org.chromium.chrome.browser.profiles.Profile;
|
|
@@ -2326,15 +2310,15 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToC
|
|
|
import org.chromium.chrome.browser.tab.Tab;
|
|
|
import org.chromium.chrome.browser.tab.TabLaunchType;
|
|
|
import org.chromium.chrome.browser.tabmodel.TabModel;
|
|
|
-@@ -46,7 +45,6 @@ import org.chromium.chrome.browser.util.ChromeAccessibilityUtil;
|
|
|
- import org.chromium.chrome.features.start_surface.StartSurfaceConfiguration;
|
|
|
+@@ -48,7 +47,6 @@ import org.chromium.chrome.features.start_surface.StartSurfaceConfiguration;
|
|
|
import org.chromium.chrome.features.start_surface.StartSurfaceUserData;
|
|
|
+ import org.chromium.components.embedder_support.util.UrlConstants;
|
|
|
import org.chromium.components.embedder_support.util.UrlUtilities;
|
|
|
-import org.chromium.components.signin.identitymanager.ConsentLevel;
|
|
|
import org.chromium.content_public.browser.LoadUrlParams;
|
|
|
import org.chromium.content_public.common.ResourceRequestBody;
|
|
|
import org.chromium.ui.base.DeviceFormFactor;
|
|
|
-@@ -512,13 +510,8 @@ public final class ReturnToChromeExperimentsUtil {
|
|
|
+@@ -527,13 +525,8 @@ public final class ReturnToChromeExperimentsUtil {
|
|
|
* Caches the status of whether the primary account is synced.
|
|
|
*/
|
|
|
public static void cachePrimaryAccountSyncStatus() {
|
|
@@ -2348,12 +2332,12 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToC
|
|
|
+ ChromePreferenceKeys.PRIMARY_ACCOUNT_SYNC, false);
|
|
|
}
|
|
|
|
|
|
- @VisibleForTesting
|
|
|
+ /**
|
|
|
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
|
--- a/chrome/browser/BUILD.gn
|
|
|
+++ b/chrome/browser/BUILD.gn
|
|
|
-@@ -2853,8 +2853,6 @@ static_library("browser") {
|
|
|
- "android/shortcut_helper.h",
|
|
|
+@@ -2880,8 +2880,6 @@ static_library("browser") {
|
|
|
+ "android/signin/fre_mobile_identity_consistency_field_trial.h",
|
|
|
"android/signin/signin_bridge.cc",
|
|
|
"android/signin/signin_bridge.h",
|
|
|
- "android/signin/signin_manager_android.cc",
|
|
@@ -2361,7 +2345,7 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
|
"android/signin/signin_metrics_utils.cc",
|
|
|
"android/signin/unified_consent_service_bridge.cc",
|
|
|
"android/signin/web_signin_bridge.cc",
|
|
|
-@@ -3178,8 +3176,6 @@ static_library("browser") {
|
|
|
+@@ -3216,8 +3214,6 @@ static_library("browser") {
|
|
|
"sharing/sms/sms_fetch_request_handler.h",
|
|
|
"shell_integration_android.cc",
|
|
|
"signin/identity_services_provider_android.cc",
|
|
@@ -2370,7 +2354,7 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
|
"ssl/chrome_security_state_client.cc",
|
|
|
"ssl/chrome_security_state_client.h",
|
|
|
"ssl/chrome_security_state_model_delegate.cc",
|
|
|
-@@ -3194,8 +3190,6 @@ static_library("browser") {
|
|
|
+@@ -3232,8 +3228,6 @@ static_library("browser") {
|
|
|
"sync/glue/synced_window_delegate_android.h",
|
|
|
"sync/glue/synced_window_delegates_getter_android.cc",
|
|
|
"sync/glue/synced_window_delegates_getter_android.h",
|
|
@@ -2379,7 +2363,7 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
|
"sync/sync_service_android_bridge.cc",
|
|
|
"sync/sync_service_android_bridge.h",
|
|
|
"sync/trusted_vault_client_android.cc",
|
|
|
-@@ -5933,10 +5927,6 @@ static_library("browser") {
|
|
|
+@@ -6037,10 +6031,6 @@ static_library("browser") {
|
|
|
"signin/logout_tab_helper.h",
|
|
|
"signin/process_dice_header_delegate_impl.cc",
|
|
|
"signin/process_dice_header_delegate_impl.h",
|
|
@@ -2537,7 +2521,7 @@ diff --git a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/brows
|
|
|
diff --git a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/SigninPromoController.java b/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/SigninPromoController.java
|
|
|
--- a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/SigninPromoController.java
|
|
|
+++ b/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/SigninPromoController.java
|
|
|
-@@ -81,20 +81,7 @@ public class SigninPromoController {
|
|
|
+@@ -82,20 +82,7 @@ public class SigninPromoController {
|
|
|
* @param accessPoint The access point for which the impression limit is being checked.
|
|
|
*/
|
|
|
public static boolean canShowSyncPromo(@AccessPoint int accessPoint) {
|
|
@@ -2558,7 +2542,7 @@ diff --git a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/brows
|
|
|
+ return false;
|
|
|
}
|
|
|
|
|
|
- private static boolean canShowBookmarkPromo() {
|
|
|
+ /**
|
|
|
diff --git a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/account_picker/AccountPickerDelegateImpl.java b/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/account_picker/AccountPickerDelegateImpl.java
|
|
|
--- a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/account_picker/AccountPickerDelegateImpl.java
|
|
|
+++ b/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/browser/signin/ui/account_picker/AccountPickerDelegateImpl.java
|
|
@@ -2579,7 +2563,7 @@ diff --git a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/brows
|
|
|
mIdentityManager = IdentityServicesProvider.get().getIdentityManager(
|
|
|
Profile.getLastUsedRegularProfile());
|
|
|
}
|
|
|
-@@ -87,25 +84,11 @@ public class AccountPickerDelegateImpl implements WebSigninBridge.Listener, Acco
|
|
|
+@@ -87,26 +84,11 @@ public class AccountPickerDelegateImpl implements WebSigninBridge.Listener, Acco
|
|
|
// if user retries the sign-in from the error screen, we need to sign out the user
|
|
|
// first before signing in again.
|
|
|
destroyWebSigninBridge();
|
|
@@ -2590,34 +2574,35 @@ diff --git a/chrome/browser/signin/ui/android/java/src/org/chromium/chrome/brows
|
|
|
AccountInfoServiceProvider.get().getAccountInfoByEmail(accountEmail).then(accountInfo -> {
|
|
|
mWebSigninBridge = mWebSigninBridgeFactory.create(
|
|
|
Profile.getLastUsedRegularProfile(), accountInfo, this);
|
|
|
-- mSigninManager.signin(accountInfo, new SigninManager.SignInCallback() {
|
|
|
-- @Override
|
|
|
-- public void onSignInComplete() {
|
|
|
-- // After the sign-in is finished in Chrome, we still need to wait for
|
|
|
-- // WebSigninBridge to be called to redirect to the continue url.
|
|
|
-- }
|
|
|
+- mSigninManager.signin(AccountUtils.createAccountFromName(accountEmail),
|
|
|
+- new SigninManager.SignInCallback() {
|
|
|
+- @Override
|
|
|
+- public void onSignInComplete() {
|
|
|
+- // After the sign-in is finished in Chrome, we still need to wait for
|
|
|
+- // WebSigninBridge to be called to redirect to the continue url.
|
|
|
+- }
|
|
|
-
|
|
|
-- @Override
|
|
|
-- public void onSignInAborted() {
|
|
|
-- AccountPickerDelegateImpl.this.destroyWebSigninBridge();
|
|
|
-- }
|
|
|
-- });
|
|
|
+- @Override
|
|
|
+- public void onSignInAborted() {
|
|
|
+- AccountPickerDelegateImpl.this.destroyWebSigninBridge();
|
|
|
+- }
|
|
|
+- });
|
|
|
});
|
|
|
}
|
|
|
|
|
|
diff --git a/chrome/browser/sync/sync_service_factory.cc b/chrome/browser/sync/sync_service_factory.cc
|
|
|
--- a/chrome/browser/sync/sync_service_factory.cc
|
|
|
+++ b/chrome/browser/sync/sync_service_factory.cc
|
|
|
-@@ -82,7 +82,7 @@
|
|
|
- #include "chromeos/lacros/lacros_service.h"
|
|
|
- #endif // BUILDFLAG(IS_CHROMEOS_LACROS)
|
|
|
+@@ -77,7 +77,7 @@
|
|
|
+ #include "chrome/browser/sync/wifi_configuration_sync_service_factory.h"
|
|
|
+ #endif // BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
|
|
-namespace {
|
|
|
+/*namespace {
|
|
|
|
|
|
std::unique_ptr<KeyedService> BuildSyncService(
|
|
|
content::BrowserContext* context) {
|
|
|
-@@ -182,7 +182,7 @@ std::unique_ptr<KeyedService> BuildSyncService(
|
|
|
+@@ -174,7 +174,7 @@ std::unique_ptr<KeyedService> BuildSyncService(
|
|
|
return sync_service;
|
|
|
}
|
|
|
|
|
@@ -2626,7 +2611,7 @@ diff --git a/chrome/browser/sync/sync_service_factory.cc b/chrome/browser/sync/s
|
|
|
|
|
|
// static
|
|
|
SyncServiceFactory* SyncServiceFactory::GetInstance() {
|
|
|
-@@ -266,7 +266,7 @@ SyncServiceFactory::~SyncServiceFactory() = default;
|
|
|
+@@ -258,7 +258,7 @@ SyncServiceFactory::~SyncServiceFactory() = default;
|
|
|
|
|
|
KeyedService* SyncServiceFactory::BuildServiceInstanceFor(
|
|
|
content::BrowserContext* context) const {
|
|
@@ -2635,7 +2620,7 @@ diff --git a/chrome/browser/sync/sync_service_factory.cc b/chrome/browser/sync/s
|
|
|
}
|
|
|
|
|
|
bool SyncServiceFactory::ServiceIsNULLWhileTesting() const {
|
|
|
-@@ -308,9 +308,3 @@ SyncServiceFactory::GetAllSyncServices() {
|
|
|
+@@ -300,9 +300,3 @@ SyncServiceFactory::GetAllSyncServices() {
|
|
|
}
|
|
|
return sync_services;
|
|
|
}
|
|
@@ -2655,10 +2640,10 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
|
|
- <message name="IDS_PREFS_MANAGE_SYNC_SETTINGS_CONTENT_DESCRIPTION" is_accessibility_with_no_ui="true" desc="The accessibility text to read when the 'Manage Sync Settings' page is opened from the sign-in page. This text is attached to the 'Navigate Up' button shown at the top of the screen. The first two sentences describe the screen that is currently shown to the user, while 'Navigate up' is a description for the button this text is attached to. 'Navigate up' should match TC ID 6794660482873516081.">
|
|
|
- You are currently customizing your Sync settings. To finish turning on sync, tap the Confirm button near the bottom of the screen. Navigate up
|
|
|
- </message>
|
|
|
- <message name="IDS_SIGNIN_PREF_DISALLOWED_TITLE" desc="Title for the signin entry in Settings when signin is disallowed.">
|
|
|
- Not signed in
|
|
|
+ <message name="IDS_SIGNIN_PREF_SUMMARY" desc="Summary for the entry in Settings to sign in to Chrome, explaining benefits of signing in.">
|
|
|
+ Sync and personalize across devices
|
|
|
</message>
|
|
|
-@@ -336,15 +333,6 @@ CHAR_LIMIT guidelines:
|
|
|
+@@ -333,15 +330,6 @@ CHAR_LIMIT guidelines:
|
|
|
<message name="IDS_URL_KEYED_ANONYMIZED_DATA_SUMMARY" desc="Summary for a checkbox in Settings that controls non-personalized URL collection and informs the user about the data shared by this feature.">
|
|
|
Sends URLs of pages you visit to Google
|
|
|
</message>
|