domQYLT.js 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313
  1. /**
  2. * Analyzes DOM queries done via native DOM methods
  3. */
  4. /* global Element: true, Document: true, Node: true, window: true */
  5. exports.version = '0.10.a';
  6. exports.module = function(phantomas) {
  7. 'use strict';
  8. phantomas.setMetric('DOMqueries'); // @desc number of all DOM queries @offenders
  9. phantomas.setMetric('DOMqueriesWithoutResults'); // @desc number of DOM queries that retutned nothing @offenders
  10. phantomas.setMetric('DOMqueriesById'); // @desc number of document.getElementById calls
  11. phantomas.setMetric('DOMqueriesByClassName'); // @desc number of document.getElementsByClassName calls
  12. phantomas.setMetric('DOMqueriesByTagName'); // @desc number of document.getElementsByTagName calls
  13. phantomas.setMetric('DOMqueriesByQuerySelectorAll'); // @desc number of document.querySelector(All) calls
  14. phantomas.setMetric('DOMinserts'); // @desc number of DOM nodes inserts
  15. phantomas.setMetric('DOMqueriesDuplicated'); // @desc number of DOM queries called more than once
  16. phantomas.setMetric('DOMqueriesAvoidable'); // @desc number of repeated uses of a duplicated query
  17. // fake native DOM functions
  18. phantomas.once('init', function() {
  19. phantomas.evaluate(function() {
  20. (function(phantomas) {
  21. function querySpy(type, query, fnName, context, hasNoResults) {
  22. phantomas.emit('domQuery', type, query, fnName, context, hasNoResults); // @desc DOM query has been made
  23. }
  24. phantomas.spy(Document.prototype, 'getElementById', function(id) {
  25. phantomas.incrMetric('DOMqueriesById');
  26. phantomas.addOffender('DOMqueriesById', '#%s (in %s)', id, '#document');
  27. phantomas.enterContext({
  28. type: 'getElementById',
  29. callDetails: {
  30. context: {
  31. domElement: '#document'
  32. },
  33. arguments: ['#' + id]
  34. },
  35. backtrace: phantomas.getBacktrace()
  36. });
  37. }, function(result, args) {
  38. var id = args[0];
  39. querySpy('id', '#' + id, 'getElementById', '#document', (result === null));
  40. var moreData = {
  41. resultsNumber : (result === null) ? 0 : 1
  42. };
  43. phantomas.leaveContext(moreData);
  44. });
  45. // selectors by class name
  46. function selectorClassNameSpyBefore(className) {
  47. /*jshint validthis: true */
  48. var context = phantomas.getDOMPath(this);
  49. phantomas.incrMetric('DOMqueriesByClassName');
  50. phantomas.addOffender('DOMqueriesByClassName', '.%s (in %s)', className, context);
  51. phantomas.enterContext({
  52. type: 'getElementsByClassName',
  53. callDetails: {
  54. context: {
  55. domElement: context
  56. },
  57. arguments: ['.' + className]
  58. },
  59. backtrace: phantomas.getBacktrace()
  60. });
  61. }
  62. function selectorClassNameAfter(result, args) {
  63. /*jshint validthis: true */
  64. var className = args[0];
  65. var context = phantomas.getDOMPath(this);
  66. querySpy('class', '.' + className, 'getElementsByClassName', context, (result.length === 0));
  67. var moreData = {
  68. resultsNumber : (result && result.length > 0) ? result.length : 0
  69. };
  70. phantomas.leaveContext(moreData);
  71. }
  72. phantomas.spy(Document.prototype, 'getElementsByClassName', selectorClassNameSpyBefore, selectorClassNameAfter);
  73. phantomas.spy(Element.prototype, 'getElementsByClassName', selectorClassNameSpyBefore, selectorClassNameAfter);
  74. // selectors by tag name
  75. function selectorTagNameSpyBefore(tagName) {
  76. /*jshint validthis: true */
  77. var context = phantomas.getDOMPath(this);
  78. phantomas.incrMetric('DOMqueriesByTagName');
  79. phantomas.addOffender('DOMqueriesByTagName', '%s (in %s)', tagName, context);
  80. phantomas.enterContext({
  81. type: 'getElementsByTagName',
  82. callDetails: {
  83. context: {
  84. domElement: context
  85. },
  86. arguments: [tagName]
  87. },
  88. backtrace: phantomas.getBacktrace()
  89. });
  90. }
  91. function selectorTagNameSpyAfter(result, args) {
  92. /*jshint validthis: true */
  93. var tagName = args[0];
  94. var context = phantomas.getDOMPath(this);
  95. querySpy('tag name', tagName.toLowerCase(), 'getElementsByTagName', context, (result.length === 0));
  96. var moreData = {
  97. resultsNumber : (result && result.length > 0) ? result.length : 0
  98. };
  99. phantomas.leaveContext(moreData);
  100. }
  101. phantomas.spy(Document.prototype, 'getElementsByTagName', selectorTagNameSpyBefore, selectorTagNameSpyAfter);
  102. phantomas.spy(Element.prototype, 'getElementsByTagName', selectorTagNameSpyBefore, selectorTagNameSpyAfter);
  103. // selector queries
  104. function selectorQuerySpy(selector, context) {
  105. phantomas.incrMetric('DOMqueriesByQuerySelectorAll');
  106. phantomas.addOffender('DOMqueriesByQuerySelectorAll', '%s (in %s)', selector, context);
  107. }
  108. function selectorQuerySpyBefore(selector) {
  109. /*jshint validthis: true */
  110. var context = phantomas.getDOMPath(this);
  111. selectorQuerySpy(selector, context);
  112. phantomas.enterContext({
  113. type: 'querySelector',
  114. callDetails: {
  115. context: {
  116. domElement: context
  117. },
  118. arguments: [selector]
  119. },
  120. backtrace: phantomas.getBacktrace()
  121. });
  122. }
  123. function selectorQuerySpyAfter(result, args) {
  124. /*jshint validthis: true */
  125. var selector = args[0];
  126. var context = phantomas.getDOMPath(this);
  127. querySpy('selector', selector, 'querySelectorAll', context, (!result || result.length === 0));
  128. var moreData = {
  129. resultsNumber : result ? 1 : 0
  130. };
  131. phantomas.leaveContext(moreData);
  132. }
  133. function selectorAllQuerySpyBefore(selector) {
  134. /*jshint validthis: true */
  135. var context = phantomas.getDOMPath(this);
  136. selectorQuerySpy(selector, context);
  137. phantomas.enterContext({
  138. type: 'querySelectorAll',
  139. callDetails: {
  140. context: {
  141. domElement: context
  142. },
  143. arguments: [selector]
  144. },
  145. backtrace: phantomas.getBacktrace()
  146. });
  147. }
  148. function selectorAllQuerySpryAfter(result, args) {
  149. /*jshint validthis: true */
  150. var selector = args[0];
  151. var context = phantomas.getDOMPath(this);
  152. querySpy('selector', selector, 'querySelectorAll', context, (!result || result.length === 0));
  153. var moreData = {
  154. resultsNumber : (result && result.length > 0) ? result.length : 0
  155. };
  156. phantomas.leaveContext(moreData);
  157. }
  158. phantomas.spy(Document.prototype, 'querySelector', selectorQuerySpyBefore, selectorQuerySpyAfter);
  159. phantomas.spy(Document.prototype, 'querySelectorAll', selectorAllQuerySpyBefore, selectorAllQuerySpryAfter);
  160. phantomas.spy(Element.prototype, 'querySelector', selectorQuerySpyBefore, selectorQuerySpyAfter);
  161. phantomas.spy(Element.prototype, 'querySelectorAll', selectorAllQuerySpyBefore, selectorAllQuerySpryAfter);
  162. // count DOM inserts
  163. function appendChild(child, element, context, appended) {
  164. /*jshint validthis: true */
  165. // ignore appending to the node that's not yet added to DOM tree
  166. if (!element.parentNode) {
  167. return;
  168. }
  169. // don't count elements added to fragments as a DOM inserts (issue #350)
  170. // DocumentFragment > div[0]
  171. if (context.indexOf('DocumentFragment') === 0) {
  172. return;
  173. }
  174. phantomas.incrMetric('DOMinserts');
  175. phantomas.addOffender('DOMinserts', '"%s" appended to "%s"', appended, context);
  176. //phantomas.log('DOM insert: node "%s" appended to "%s"', appended, context);
  177. }
  178. function appendChildSpyBefore(child) {
  179. /*jshint validthis: true */
  180. var context = phantomas.getDOMPath(this);
  181. var appended = phantomas.getDOMPath(child);
  182. appendChild(child, this, context, appended);
  183. phantomas.enterContext({
  184. type: 'appendChild',
  185. callDetails: {
  186. context: {
  187. domElement: context
  188. },
  189. arguments: [appended]
  190. },
  191. backtrace: phantomas.getBacktrace()
  192. });
  193. }
  194. function insertBeforeSpyBefore(child) {
  195. /*jshint validthis: true */
  196. var context = phantomas.getDOMPath(this);
  197. var appended = phantomas.getDOMPath(child);
  198. appendChild(child, this, context, appended);
  199. phantomas.enterContext({
  200. type: 'insertBefore',
  201. callDetails: {
  202. context: {
  203. domElement: context
  204. },
  205. arguments: [appended]
  206. },
  207. backtrace: phantomas.getBacktrace()
  208. });
  209. }
  210. phantomas.spy(Node.prototype, 'appendChild', appendChildSpyBefore, function(result) {
  211. phantomas.leaveContext();
  212. });
  213. phantomas.spy(Node.prototype, 'insertBefore', insertBeforeSpyBefore, function(result) {
  214. phantomas.leaveContext();
  215. });
  216. })(window.__phantomas);
  217. });
  218. });
  219. // report DOM queries that return no results (issue #420)
  220. phantomas.on('domQuery', function(type, query, fnName, context, hasNoResults) {
  221. // ignore DOM queries within DOM fragments (used internally by jQuery)
  222. if (context.indexOf('body') !== 0 && context.indexOf('#document') !== 0) {
  223. return;
  224. }
  225. if (hasNoResults === true) {
  226. phantomas.incrMetric('DOMqueriesWithoutResults');
  227. phantomas.addOffender('DOMqueriesWithoutResults', '%s (in %s) using %s', query, context, fnName);
  228. }
  229. });
  230. // count DOM queries by either ID, tag name, class name and selector query
  231. // @see https://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-document-doctype
  232. var Collection = require('../../../../../../node_modules/phantomas/lib/collection'),
  233. DOMqueries = new Collection();
  234. phantomas.on('domQuery', function(type, query, fnName, context) {
  235. phantomas.log('DOM query: by %s - "%s" (using %s) in %s', type, query, fnName, context);
  236. phantomas.incrMetric('DOMqueries');
  237. if (context && context.indexOf('DocumentFragment') === -1) {
  238. DOMqueries.push(type + ' "' + query + '" with ' + fnName + ' (in context ' + context + ')');
  239. }
  240. });
  241. phantomas.on('report', function() {
  242. DOMqueries.sort().forEach(function(query, cnt) {
  243. if (cnt > 1) {
  244. phantomas.incrMetric('DOMqueriesDuplicated');
  245. phantomas.incrMetric('DOMqueriesAvoidable', cnt - 1);
  246. phantomas.addOffender('DOMqueriesDuplicated', '%s: %d queries', query, cnt);
  247. }
  248. });
  249. });
  250. };