Explorar o código

Removing the jQuery Usage rule

Gaël Métais %!s(int64=8) %!d(string=hai) anos
pai
achega
f2f27ac639

+ 0 - 9
lib/metadata/policies.js

@@ -343,15 +343,6 @@ var policies = {
         "isAbnormalThreshold": 2,
         "hasOffenders": true
     },
-    "jQueryFunctionsUsed": {
-        "tool": "jsExecutionTransformer",
-        "label": "jQuery usage",
-        "message": "<p>This is the number of different core jQuery functions called on load. This rule is not trying to blame you for using jQuery too much, but the opposite.</p><p>If only a few functions are used, why not trying to get rid of jQuery? Have a look at <a href=\"http://youmightnotneedjquery.com/\" target=\"_blank\">http://youmightnotneedjquery.com</a>.</p>",
-        "isOkThreshold": 15,
-        "isBadThreshold": 6,
-        "isAbnormalThreshold": 0,
-        "hasOffenders": true
-    },
     "jQueryCallsOnEmptyObject": {
         "tool": "jsExecutionTransformer",
         "label": "Calls on empty objects",

+ 0 - 1
lib/metadata/scoreProfileGeneric.json

@@ -61,7 +61,6 @@
             "policies": {
                 "jQueryVersion": 2,
                 "jQueryVersionsLoaded": 2,
-                "jQueryFunctionsUsed": 1,
                 "jQueryCallsOnEmptyObject": 1,
                 "jQueryNotDelegatedEvents": 1
             }

+ 0 - 18
lib/tools/jsExecutionTransformer.js

@@ -25,11 +25,8 @@ var jsExecutionTransformer = function() {
         var hasjQuery = (data.toolsResults.phantomas.metrics.jQueryVersionsLoaded > 0);
         if (hasjQuery) {
             metrics.jQueryCalls = 0;
-            metrics.jQueryFunctionsUsed = 0;
             metrics.jQueryCallsOnEmptyObject = 0;
             metrics.jQueryNotDelegatedEvents = 0;
-
-            offenders.jQueryFunctionsUsed = [];
         }
 
         try {
@@ -102,21 +99,6 @@ var jsExecutionTransformer = function() {
                     metrics.DOMaccesses += countTreeLeafs(node);
                 });
 
-                // Count the number of different jQuery functions called
-                if (hasjQuery) {
-
-                    jQueryFunctionsCollection.sort().forEach(function(fnName, cnt) {
-                        if (fnName === 'jQuery - find') {
-                            fnName = 'jQuery - $';
-                        }
-                        metrics.jQueryFunctionsUsed ++;
-                        offenders.jQueryFunctionsUsed.push({
-                            functionName: fnName.substring(9),
-                            count: cnt
-                        });
-                    });
-                }
-
             }
             debug('JS execution transformation complete');