浏览代码

Remove the Tweet this button

Gaël Métais 4 年之前
父节点
当前提交
3f5c54d5de
共有 4 个文件被更改,包括 3 次插入105 次删除
  1. 0 34
      front/src/css/dashboard.css
  2. 0 23
      front/src/js/controllers/dashboardCtrl.js
  3. 0 33
      front/src/less/dashboard.less
  4. 3 15
      front/src/views/dashboard.html

+ 0 - 34
front/src/css/dashboard.css

@@ -202,40 +202,6 @@
 .summary .notations .criteria .info svg {
   fill: transparent;
 }
-.summary .fromShare {
-  margin-bottom: 3em;
-}
-.summary .tweet {
-  display: none;
-}
-@media (min-width: 820px) {
-  .summary .tweet {
-    display: block;
-  }
-}
-.summary .tweet .tweetText {
-  color: #212240;
-  background: #F2F2F2;
-  border: none;
-  width: 25em;
-  padding: 0.4em;
-  border-radius: 0.5em;
-  box-shadow: 0.05em 0.1em 0 0 #999;
-}
-.summary .tweet .tweetButton,
-.summary .tweet .linkedinButton {
-  color: #212240;
-  background: #F2F2F2;
-  margin-right: 0;
-}
-.summary .tweet .tweetButton:hover,
-.summary .tweet .linkedinButton:hover {
-  color: #F2F2F2;
-  background: #e74c3c;
-}
-.summary .tweet input {
-  font-size: 0.9em;
-}
 .summary .sponsor {
   font-size: 0.9em;
   margin-bottom: 4em;

+ 0 - 23
front/src/js/controllers/dashboardCtrl.js

@@ -3,7 +3,6 @@ var dashboardCtrl = angular.module('dashboardCtrl', ['resultsFactory', 'menuServ
 dashboardCtrl.controller('DashboardCtrl', ['$scope', '$rootScope', '$routeParams', '$location', 'Results', 'API', 'Menu', function($scope, $rootScope, $routeParams, $location, Results, API, Menu) {
     $scope.runId = $routeParams.runId;
     $scope.Menu = Menu.setCurrentPage('dashboard', $scope.runId);
-    $scope.fromSocialShare = $location.search().share;
     
     function loadResults() {
         // Load result if needed
@@ -34,27 +33,5 @@ dashboardCtrl.controller('DashboardCtrl', ['$scope', '$rootScope', '$routeParams
         API.relaunchTest($scope.result);
     };
 
-    // When comming from a social shared link, the user needs to click on "See full report" button to display the full dashboard.
-    $scope.seeFullReport = function() {
-        $scope.fromSocialShare = false;
-        $location.search({});
-    };
-
-    $scope.shareOnTwitter = function(message) {
-        openSocialPopup('https://twitter.com/intent/tweet?text=' + encodeURIComponent(message + 'https://yellowlab.tools'));
-    };
-
-    $scope.shareOnLinkedin = function(message) {
-        openSocialPopup('https://www.linkedin.com/shareArticle?mini=true&url=https://yellowlab.tools&title=' + encodeURIComponent(message) + '&summary=' + encodeURIComponent('YellowLabTools is a free online tool that analyzes performance and front-end quality of a webpage.'));
-    };
-
-    function openSocialPopup(url) {
-        var winHeight = 400;
-        var winWidth = 600;
-        var winTop = (screen.height / 2) - (winHeight / 2);
-        var winLeft = (screen.width / 2) - (winWidth / 2);
-        window.open(url, 'sharer', 'top=' + winTop + ',left=' + winLeft + ',toolbar=0,status=0,width=' + winWidth + ',height=' + winHeight);
-    }
-
     loadResults();
 }]);

+ 0 - 33
front/src/less/dashboard.less

@@ -189,39 +189,6 @@
     fill: transparent;
 }
 
-.summary .fromShare {
-    margin-bottom: 3em;
-}
-
-.summary .tweet {
-    display: none;
-    @media (min-width: 820px) {
-        display: block;
-    }
-
-    .tweetText {
-        color: #212240;
-        background: #F2F2F2;
-        border: none;
-        width: 25em;
-        padding: 0.4em;
-        border-radius: 0.5em;
-        box-shadow: 0.05em 0.1em 0 0 #999;
-    }
-    .tweetButton, .linkedinButton {
-        color: #212240;
-        background: #F2F2F2;
-        margin-right: 0;
-        &:hover {
-            color: #F2F2F2;
-            background: #e74c3c;
-        }
-    }
-    input {
-        font-size: 0.9em;
-    }
-}
-
 .summary .sponsor {
     font-size: 0.9em;
     margin-bottom: 4em;

+ 3 - 15
front/src/views/dashboard.html

@@ -60,23 +60,11 @@
     <% } %>
 
     <%if (sponsoring.dashboard) { %>
-        <div ng-if="!error && !fromSocialShare" class="sponsor"><%- sponsoring.dashboard %></div>
+        <div ng-if="!error" class="sponsor"><%- sponsoring.dashboard %></div>
     <% } %>
-    
-
-    <div class="tweet" ng-if="!error && !fromSocialShare">
-        <form ng-submit="sendTweet()">
-            <input type="text" class="tweetText" ng-model="tweetText">
-            <input type="submit" class="tweetButton" value="Tweet this!" ng-click="shareOnTwitter(tweetText)">
-            <input type="submit" class="linkedinButton" value="LinkedIn this!" ng-click="shareOnLinkedin(tweetText)">
-        </form>
-    </div>
 
-    <div class="fromShare" ng-if="!error && fromSocialShare">
-        <p>Yellow Lab Tools is a free online tool that analyzes performance and front-end quality.</p>
-        <a class="linkButton" href="" ng-click="seeFullReport()">See the full report for this page</a>
-        <a class="linkButton" href="<%= baseUrl %>">Test another webpage</a>
-    </div>
+    
+    
 
     <div ng-if="error">
         <h2>Run failed / Run not found</h2>