Просмотр исходного кода

Working on implementing unicode ranges again

Gaël Métais 4 лет назад
Родитель
Сommit
36fc0f0e10
3 измененных файлов с 8 добавлено и 5 удалено
  1. 2 2
      lib/metadata/scoreProfileGeneric.json
  2. 6 0
      lib/runner.js
  3. 0 3
      lib/tools/redownload/redownload.js

+ 2 - 2
lib/metadata/scoreProfileGeneric.json

@@ -86,8 +86,8 @@
             "policies": {
             "policies": {
                 "fontsCount": 1,
                 "fontsCount": 1,
                 "heavyFonts": 0.5,
                 "heavyFonts": 0.5,
-                "nonWoff2Fonts": 0.5,
-                "unusedUnicodeRanges": 0.1
+                "unusedUnicodeRanges": 0.5,
+                "nonWoff2Fonts": 0.5
             }
             }
         },
         },
         "serverConfig": {
         "serverConfig": {

+ 6 - 0
lib/runner.js

@@ -78,6 +78,12 @@ var Runner = function(params) {
             milestone: 'redownload'
             milestone: 'redownload'
         });
         });
 
 
+        // Fix: don't display Unicode ranges if the module is not present in Phantomas
+        if (!data.toolsResults.phantomas.metrics.charactersCount) {
+            delete data.toolsResults.redownload.metrics.unusedUnicodeRanges;
+            delete data.toolsResults.redownload.offenders.unusedUnicodeRanges;
+        }
+
         // Rules checker
         // Rules checker
         var policies = require('./metadata/policies');
         var policies = require('./metadata/policies');
         data.rules = rulesChecker.check(data, policies);
         data.rules = rulesChecker.check(data, policies);

+ 0 - 3
lib/tools/redownload/redownload.js

@@ -21,7 +21,6 @@ var brotliCompressor    = require('./brotliCompressor');
 var contentTypeChecker  = require('./contentTypeChecker');
 var contentTypeChecker  = require('./contentTypeChecker');
 var fontAnalyzer        = require('./fontAnalyzer');
 var fontAnalyzer        = require('./fontAnalyzer');
 var imageDimensions     = require('./imageDimensions');
 var imageDimensions     = require('./imageDimensions');
-var cdnDetector         = require('./cdnDetector/cdnDetector');
 
 
 
 
 var Redownload = function() {
 var Redownload = function() {
@@ -76,8 +75,6 @@ var Redownload = function() {
                 
                 
                 redownloadEntry(entry, httpAuth, proxy)
                 redownloadEntry(entry, httpAuth, proxy)
 
 
-                .then(cdnDetector.detectCDN)
-
                 .then(contentTypeChecker.checkContentType)
                 .then(contentTypeChecker.checkContentType)
 
 
                 .then(imageOptimizer.optimizeImage)
                 .then(imageOptimizer.optimizeImage)