Prepending "x" to test arguments isn't needed if proper
quoting is used; POSIX is pretty clear on that.
This confusing x prefix has also masked a bug on line 99,
where a condition was never true due to a missing x on
the right side of the comparison.
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Prepending "x" to test arguments isn't needed if proper
quoting is used; POSIX is pretty clear on that.
This confusing x prefix has also masked a bug on line 99,
where a condition was never true due to a missing x on
the right side of the comparison.
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: Thanh Tung Nguyen <thngtong@gmail.com>
[rebased to the latest upstream code]
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: Thanh Tung Nguyen <thngtong@gmail.com>
[rebased to the latest upstream code]
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: Jo Shields <directhex@apebox.org>
[adjusted the patch to the new upstream build code]
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: Jo Shields <directhex@apebox.org>
[adjusted the patch to the new upstream build code]
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
I was working on a script of mine and I realized the way I wrote the test commands do not work. They need a space between the curly braces and a semicolon at the end in order to work.
I was working on a script of mine and I realized the way I wrote the test commands do not work. They need a space between the curly braces and a semicolon at the end in order to work.
I did a rough sketch of how this would work. Please consider changing revising where appropriate.
- What does this change do?
Basic checking of sha256 of a file. My change calculates the hash of the file it downloads and also downloads a list of hashes, we then compare the first 64 characters, the hash, that the pc calculates to the hash it downloaded.
Should there be a mismatch or if a file fails to download, the script will exit 1. Please change as you feel necessary.
*ps.
I'm not sure if the script should eval the hashes right before it compares them or if the way I evaluate the variables is ok. Also I did not use grep as I have been told it was bad.
I did a rough sketch of how this would work. Please consider changing revising where appropriate.
- What does this change do?
Basic checking of sha256 of a file. My change calculates the hash of the file it downloads and also downloads a list of hashes, we then compare the first 64 characters, the hash, that the pc calculates to the hash it downloaded.
Should there be a mismatch or if a file fails to download, the script will exit 1. Please change as you feel necessary.
*ps.
I'm not sure if the script should eval the hashes right before it compares them or if the way I evaluate the variables is ok. Also I did not use grep as I have been told it was bad.
