Explorar o código

feat: rm page limit

xiaobing.wang hai 1 ano
pai
achega
d3582a86ab
Modificáronse 2 ficheiros con 2 adicións e 14 borrados
  1. 1 12
      backend/internal/handler/github.go
  2. 1 2
      backend/main.go

+ 1 - 12
backend/internal/handler/github.go

@@ -11,14 +11,12 @@ import (
 // GitHubHandler provides HTTP handlers for GitHub operations.
 type GitHubHandler struct {
 	gitHubService *service.GitHubService
-	pageLimit     int
 }
 
 // NewGitHubHandler creates a new instance of GitHubHandler.
-func NewGitHubHandler(gitHubService *service.GitHubService, pageLimit int) *GitHubHandler {
+func NewGitHubHandler(gitHubService *service.GitHubService) *GitHubHandler {
 	return &GitHubHandler{
 		gitHubService: gitHubService,
-		pageLimit:     pageLimit,
 	}
 }
 
@@ -39,10 +37,6 @@ func (h *GitHubHandler) GetIssues(c *gin.Context) {
 		c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
 		return
 	}
-	if len(issues) > h.pageLimit {
-		c.JSON(http.StatusOK, issues[:h.pageLimit])
-		return
-	}
 	c.JSON(http.StatusOK, issues)
 }
 
@@ -64,10 +58,5 @@ func (h *GitHubHandler) GetDiscussions(c *gin.Context) {
 		return
 	}
 
-	if len(discussions) > h.pageLimit {
-		c.JSON(http.StatusOK, discussions[:h.pageLimit])
-		return
-	}
-
 	c.JSON(http.StatusOK, discussions)
 }

+ 1 - 2
backend/main.go

@@ -21,7 +21,6 @@ func main() {
 
 	// optional variables to set
 	viper.SetDefault("GITHUB_CACHE_TTL", 10) // cache timeout in minutes
-	viper.SetDefault("PAGE_LIMIT", 25)       // the number max returned
 	viper.SetDefault("LISTEN_ADDR", ":8080") // api server addr
 
 	githubToken := viper.GetString("GITHUB_TOKEN")
@@ -41,7 +40,7 @@ func main() {
 	})
 
 	// Create a new instance of GitHubHandler.
-	gitHubHandler := handler.NewGitHubHandler(gitHubService, viper.GetInt("PAGE_LIMIT"))
+	gitHubHandler := handler.NewGitHubHandler(gitHubService)
 
 	v1 := r.Group("/api")
 	v1.GET("/repos/issues", gitHubHandler.GetIssues)