0ct0pu5/Pico
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid using global config variable.

Browse source 
Instead config is keeped in Pico::$config private variable, and the
config.php returns $config.
This commit is contained in:
Wojciech Grzebieniowski 2015-06-09 12:01:11 +02:00
parent 48e5c9e500
commit 23b90e2a92
2 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
config.php.template
View file

@ -49,3 +49,6 @@
* CUSTOM * CUSTOM
*/ */
// $config['custom_setting'] = 'Hello'; // Can be accessed by {{ config.custom_setting }} in a theme // $config['custom_setting'] = 'Hello'; // Can be accessed by {{ config.custom_setting }} in a theme
// Keep this line
return $config;

18
lib/pico.php
View file

@ -10,6 +10,7 @@
*/ */
class Pico { class Pico {
private $config;
private $plugins; private $plugins;
/** /**
@ -150,7 +151,7 @@ class Pico {
*/ */
protected function read_file_meta($content) protected function read_file_meta($content)
{ {
global $config; $config = $this->config;
$headers = array( $headers = array(
'title' => 'Title', 'title' => 'Title',
@ -184,8 +185,8 @@ class Pico {
*/ */
protected function get_config() protected function get_config()
{ {
global $config;
@include_once(ROOT_DIR .'config.php'); $this->config = @include_once(ROOT_DIR .'config.php');
$defaults = array( $defaults = array(
'site_title' => 'Pico', 'site_title' => 'Pico',
@ -199,10 +200,10 @@ class Pico {
'content_dir' => 'content-sample/', 'content_dir' => 'content-sample/',
); );
if(is_array($config)) $config = array_merge($defaults, $config); if(is_array($this->config)) $this->config = array_merge($defaults, $this->config);
else $config = $defaults; else $this->config = $defaults;
return $config; return $this->config;
} }
/** /**
@ -215,7 +216,7 @@ class Pico {
*/ */
protected function get_pages($base_url, $order_by = 'alpha', $order = 'asc', $excerpt_length = 50) protected function get_pages($base_url, $order_by = 'alpha', $order = 'asc', $excerpt_length = 50)
{ {
global $config; $config = $this->config;
$pages = $this->get_files($config['content_dir'], CONTENT_EXT); $pages = $this->get_files($config['content_dir'], CONTENT_EXT);
$sorted_pages = array(); $sorted_pages = array();
@ -292,7 +293,8 @@ class Pico {
*/ */
protected function base_url() protected function base_url()
{ {
global $config; $config = $this->config;
if(isset($config['base_url']) && $config['base_url']) return $config['base_url']; if(isset($config['base_url']) && $config['base_url']) return $config['base_url'];
$url = ''; $url = '';