123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223 |
- <?php
- namespace Tests\Api\v1\Controllers;
- use App\Api\v1\Controllers\IconController;
- use App\Facades\IconStore;
- use App\Models\TwoFAccount;
- use App\Models\User;
- use Illuminate\Http\Testing\FileFactory;
- use Illuminate\Http\UploadedFile;
- use Illuminate\Support\Facades\Http;
- use Illuminate\Support\Facades\Storage;
- use PHPUnit\Framework\Attributes\CoversClass;
- use PHPUnit\Framework\Attributes\Test;
- use Tests\Classes\LocalFile;
- use Tests\Data\CommonDataProvider;
- use Tests\Data\HttpRequestTestData;
- use Tests\Data\OtpTestData;
- use Tests\FeatureTestCase;
- /**
- * IconController test class
- */
- #[CoversClass(IconController::class)]
- class IconControllerTest extends FeatureTestCase
- {
- /**
- * @var \App\Models\User|\Illuminate\Contracts\Auth\Authenticatable
- */
- protected $user;
- protected function setUp() : void
- {
- parent::setUp();
- Storage::fake('icons');
- Storage::fake('logos');
- Http::preventStrayRequests();
- Http::fake([
- OtpTestData::EXTERNAL_IMAGE_URL_DECODED => Http::response((new FileFactory)->image('file.png', 10, 10)->tempFile, 200),
- ]);
- $this->user = User::factory()->create();
- }
- #[Test]
- public function test_upload_icon_returns_filename_using_the_iconStore()
- {
- $iconName = 'testIcon.jpg';
- $file = UploadedFile::fake()->image($iconName);
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons', [
- 'icon' => $file,
- ])
- ->assertCreated()
- ->assertJsonStructure([
- 'filename',
- ]);
- }
- #[Test]
- public function test_upload_icon_stores_it_to_database()
- {
- $file = UploadedFile::fake()->image('testIcon.jpg');
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons', [
- 'icon' => $file,
- ]);
- }
- #[Test]
- public function test_upload_with_invalid_data_returns_validation_error()
- {
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons', [
- 'icon' => null,
- ])
- ->assertStatus(422);
- }
- #[Test]
- public function test_upload_infected_svg_data_stores_stores_sanitized_svg_content()
- {
- $file = LocalFile::fake()->infectedSvgIconFile();
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons', [
- 'icon' => $file,
- ])
- ->assertCreated();
- $svgContent = IconStore::get($response->getData()->filename);
- $this->assertStringNotContainsString(OtpTestData::ICON_SVG_MALICIOUS_CODE, $svgContent);
- }
- #[Test]
- public function test_fetch_logo_returns_filename()
- {
- Http::fake([
- CommonDataProvider::SELFH_URL => Http::response(HttpRequestTestData::SVG_LOGO_BODY, 200),
- ]);
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons/default', [
- 'service' => 'service',
- ])
- ->assertStatus(201)
- ->assertJsonStructure([
- 'filename',
- ]);
- }
- #[Test]
- public function test_fetch_logo_using_specified_icon_collection_returns_filename()
- {
- Http::fake([
- CommonDataProvider::SELFH_URL => Http::response(HttpRequestTestData::SVG_LOGO_BODY, 200),
- CommonDataProvider::DASHBOARDICONS_URL => Http::response(OtpTestData::ICON_SVG_DATA, 200),
- ]);
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons/default', [
- 'service' => 'service',
- 'iconCollection' => 'dashboardicons',
- ])
- ->assertStatus(201)
- ->assertJsonStructure([
- 'filename',
- ]);
- // Don't know why but 'getData()->filename' has some unwanted spaces in it so we trim them
- $svgContent = trim(str_replace('> <', '><', IconStore::get($response->getData()->filename)));
- $this->assertEquals(OtpTestData::ICON_SVG_DATA, $svgContent);
- }
- #[Test]
- public function test_fetch_logo_return_validation_error()
- {
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons/default', [
- 'service' => 'service',
- 'iconCollection' => 'not_a_valid_icon_collection',
- ])
- ->assertStatus(422);
- }
- #[Test]
- public function test_fetch_logo_with_infected_svg_data_stores_sanitized_svg_content()
- {
- Http::fake([
- CommonDataProvider::SELFH_URL => Http::response(OtpTestData::ICON_SVG_DATA_INFECTED, 200),
- ]);
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons/default', [
- 'service' => 'service',
- ])
- ->assertStatus(201)
- ->assertJsonStructure([
- 'filename',
- ]);
- $svgContent = IconStore::get($response->getData()->filename);
- $this->assertStringNotContainsString(OtpTestData::ICON_SVG_MALICIOUS_CODE, $svgContent);
- }
- #[Test]
- public function test_fetch_unknown_logo_returns_nothing()
- {
- Http::fake([
- CommonDataProvider::SELFH_URL => Http::response('not found', 404),
- ]);
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('POST', '/api/v1/icons/default', [
- 'service' => 'NameOfAnUnknownServiceForSure',
- ])
- ->assertNoContent();
- }
- #[Test]
- public function test_delete_icon_returns_success_using_the_iconStore()
- {
- IconStore::spy();
- $iconName = 'testIcon.jpg';
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('DELETE', '/api/v1/icons/' . $iconName)
- ->assertNoContent(204);
- IconStore::shouldHaveReceived('delete')->once()->with($iconName);
- }
- #[Test]
- public function test_delete_invalid_icon_returns_success()
- {
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('DELETE', '/api/v1/icons/null')
- ->assertNoContent(204);
- }
- #[Test]
- public function test_delete_icon_of_another_user_is_forbidden()
- {
- $anotherUser = User::factory()->create();
- TwoFAccount::factory()->for($anotherUser)->create([
- 'icon' => 'testIcon.jpg',
- ]);
- $response = $this->actingAs($this->user, 'api-guard')
- ->json('DELETE', '/api/v1/icons/testIcon.jpg')
- ->assertForbidden()
- ->assertJsonStructure([
- 'message',
- ]);
- }
- }
|