浏览代码

Refactor LogoService resolution

Bubka 2 年之前
父节点
当前提交
7ce7067380
共有 1 个文件被更改,包括 3 次插入4 次删除
  1. 3 4
      app/Api/v1/Controllers/IconController.php

+ 3 - 4
app/Api/v1/Controllers/IconController.php

@@ -5,7 +5,6 @@ namespace App\Api\v1\Controllers;
 use App\Http\Controllers\Controller;
 use App\Http\Controllers\Controller;
 use App\Services\LogoService;
 use App\Services\LogoService;
 use Illuminate\Http\Request;
 use Illuminate\Http\Request;
-use Illuminate\Support\Facades\App;
 use Illuminate\Support\Facades\Storage;
 use Illuminate\Support\Facades\Storage;
 
 
 class IconController extends Controller
 class IconController extends Controller
@@ -34,16 +33,16 @@ class IconController extends Controller
      * Fetch a logo
      * Fetch a logo
      *
      *
      * @param  \Illuminate\Http\Request  $request
      * @param  \Illuminate\Http\Request  $request
+     * @param  \App\Services\LogoService  $logoService
      * @return \Illuminate\Http\JsonResponse
      * @return \Illuminate\Http\JsonResponse
      */
      */
-    public function fetch(Request $request)
+    public function fetch(Request $request, LogoService $logoService)
     {
     {
         $this->validate($request, [
         $this->validate($request, [
             'service' => 'string|regex:/^[^:]+$/i',
             'service' => 'string|regex:/^[^:]+$/i',
         ]);
         ]);
 
 
-        $logoService = App::make(LogoService::class);
-        $icon        = $logoService->getIcon($request->service);
+        $icon = $logoService->getIcon($request->service);
 
 
         return $icon
         return $icon
             ? response()->json(['filename' => $icon], 201)
             ? response()->json(['filename' => $icon], 201)